Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composing any email fails if a signature is set on the sending account #1468

Closed
mpnordland opened this issue Feb 15, 2020 · 1 comment
Closed

Comments

@mpnordland
Copy link
Contributor

Describe the bug
Composing any email fails if a signature is set on the sending account

Software Versions

  • Python version: 3.8
  • Alot version: 0.9

To Reproduce
Steps to reproduce the behaviour:

  1. Open Alot
  2. Press 'm' to compose
  3. Press enter to confirm from address
  4. See error

Error Log

DEBUG:ui:Got key (['m'], [109])
DEBUG:ui:cmdline: 'compose'
DEBUG:ui:search command string: "compose"
DEBUG:__init__:mode:search got commandline "compose"
DEBUG:__init__:ARGS: ['compose']
DEBUG:__init__:cmd parms {'sender': None, 'template': None, 'tags': None, 'subject': None, 'to': None, 'cc': None, 'bcc': None, 'attach': None, 'omit_signature': False, 'spawn': None, 'rest': []}
DEBUG:envelope:TEMPLATE: None
DEBUG:ui:Got key (['enter'], [10])
DEBUG:globals:has signature
DEBUG:globals:is file
ERROR:ui:Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/alot/ui.py", line 716, in apply_command
    await cmd.apply(self)
  File "/usr/lib/python3.8/site-packages/alot/commands/globals.py", line 882, in apply
    await self.__apply(ui)
  File "/usr/lib/python3.8/site-packages/alot/commands/globals.py", line 1022, in __apply
    await self._set_signature(ui)
  File "/usr/lib/python3.8/site-packages/alot/commands/globals.py", line 872, in _set_signature
    self.envelope.body += '\n' + sigcontent
AttributeError: 'Envelope' object has no attribute 'body'
@pazz pazz closed this as completed in 28a4296 Feb 16, 2020
@pazz
Copy link
Owner

pazz commented Feb 16, 2020 via email

pacien added a commit to pacien/nixpkgs that referenced this issue Mar 9, 2020
This version is not usable without this patch.
See pazz/alot#1468.
pacien added a commit to pacien/nixpkgs that referenced this issue Mar 10, 2020
This version is not usable without this patch.
See pazz/alot#1468.

(cherry picked from commit b6d4530)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Mar 10, 2020
This version is not usable without this patch.
See pazz/alot#1468.

(cherry picked from commit b6d4530)
ryneeverett pushed a commit to ryneeverett/alot that referenced this issue Mar 13, 2020
which now should be body_txt as of e067ea2

fixes pazz#1468
@rien rien mentioned this issue May 2, 2020
GuillaumeSeren pushed a commit to GuillaumeSeren/alot that referenced this issue Oct 3, 2021
which now should be body_txt as of e067ea2

fixes pazz#1468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants