Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mailcap rendering for e-mails without Content-Type header #1513

Merged
merged 1 commit into from May 19, 2020
Merged

Fix mailcap rendering for e-mails without Content-Type header #1513

merged 1 commit into from May 19, 2020

Conversation

mmartin
Copy link
Contributor

@mmartin mmartin commented May 19, 2020

get_params() returns None when the header is missing. Use failobj argument to mitigate that.

Fixes #1512

Fix mailcap rendering for e-mails without Content-Type header
1e2e392 
`get_params()` returns `None` when the header is missing. Use `failobj`
argument to mitigate that.

Fixes pazz#1512
@pazz
Copy link
Owner

pazz commented May 19, 2020

Thanks!

@pazz pazz merged commit 2348014 into pazz:master May 19, 2020
devvesa added a commit to devvesa/void-packages that referenced this pull request Oct 31, 2020
@devvesa
alot: patch mailcap rendering no content-type
ec56e7e 
Add a patch to fix a rendering problem with mails without Content-Type
header.

Patch is based on a bug already fixed in master in this PR:

pazz/alot#1513

I find it important because without it, there is no way to see any mail
sent via `git send-email` on projects with email-driven git workflows.
Apparently, `git send-email` doesn't add the aforementioned header.
@devvesa devvesa mentioned this pull request Oct 31, 2020
Merged
@devvesa
Copy link

devvesa commented Oct 31, 2020 •
edited

@pazz : You might want to create a minor release with this particular fix. It turns out that all the mails sent via git send-email don't have Content-Type header and alot fails on rendering them with the current release. So all the email-driven workflow projects are being affected.

I already added the patch of this PR on void-linux:

void-linux/void-packages#25997

But I ignore what's the experience with the rest of linux distributions.

If you are already aware of this, or you don't find it important, just disregard my message :)

@pazz
Copy link
Owner

pazz commented Oct 31, 2020

thanks for making me aware!
I could make a minor release soonish, OK.
This will likely introduce other issues as the move to the new notmuch2 bindings has been merged recently as well, buy hey😁

@ericonr
Copy link

ericonr commented Oct 31, 2020

If you think it makes sense, making a minor release on a separate branch that only backports this fix could work as well :)

ericonr pushed a commit to void-linux/void-packages that referenced this pull request Oct 31, 2020
@devvesa @ericonr
alot: patch mailcap rendering no content-type
bc3b09a 
Add a patch to fix a rendering problem with mails without Content-Type
header.

Patch is based on a bug already fixed in master in this PR:

pazz/alot#1513

I find it important because without it, there is no way to see any mail
sent via `git send-email` on projects with email-driven git workflows.
Apparently, `git send-email` doesn't add the aforementioned header.
@devvesa
Copy link

devvesa commented Oct 31, 2020

Glad to help @pazz .

Logarithmus pushed a commit to Logarithmus/void-packages that referenced this pull request Nov 15, 2020
@devvesa @Logarithmus
alot: patch mailcap rendering no content-type
2cd7d77 
Add a patch to fix a rendering problem with mails without Content-Type
header.

Patch is based on a bug already fixed in master in this PR:

pazz/alot#1513

I find it important because without it, there is no way to see any mail
sent via `git send-email` on projects with email-driven git workflows.
Apparently, `git send-email` doesn't add the aforementioned header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazz pazz pazz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to open e-mails without Content-Type header
4 participants
@mmartin @pazz @devvesa @ericonr