You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like mock is only used for the docs, so I would suggest removing it from install_requires.
Also, since it is included as unittest.mock in Python 3.3+, I would suggest using 'mock;python_version<"3.3"' to only pull it when needed. Commit 76a79ae already provides support for it.
The text was updated successfully, but these errors were encountered:
________________________________
From: Louis Leseur <notifications@github.com>
Sent: Tuesday, August 25, 2020 10:17:40 PM
To: pazz/urwidtrees <urwidtrees@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [pazz/urwidtrees] setup.py: mock should not be in both install_requires and extras_require (#48)
It looks like mock is only used for the docs, so I would suggest removing it from install_requires.
Also, since it is included as unittest.mock in Python 3.3+, I would suggest using 'mock;python_version<"3.3"' to only pull it when needed. Commit 76a79ae<76a79ae> already provides support for it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#48>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEZNZ6VMCN3GY6K2NUSC6DSCQS7JANCNFSM4QLDEETQ>.
teapot9
added a commit
to teapot9/urwidtrees
that referenced
this issue
Aug 26, 2020
It looks like mock is only used for the docs, so I would suggest removing it from install_requires.
Also, since it is included as unittest.mock in Python 3.3+, I would suggest using
'mock;python_version<"3.3"'
to only pull it when needed. Commit 76a79ae already provides support for it.The text was updated successfully, but these errors were encountered: