Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: mock should not be in both install_requires and extras_require #48

Closed
teapot9 opened this issue Aug 25, 2020 · 1 comment · Fixed by #49
Closed

setup.py: mock should not be in both install_requires and extras_require #48

teapot9 opened this issue Aug 25, 2020 · 1 comment · Fixed by #49

Comments

@teapot9
Copy link
Contributor

teapot9 commented Aug 25, 2020

It looks like mock is only used for the docs, so I would suggest removing it from install_requires.

Also, since it is included as unittest.mock in Python 3.3+, I would suggest using 'mock;python_version<"3.3"' to only pull it when needed. Commit 76a79ae already provides support for it.

@pazz
Copy link
Owner

pazz commented Aug 26, 2020 via email

teapot9 added a commit to teapot9/urwidtrees that referenced this issue Aug 26, 2020
@pazz pazz closed this as completed in #49 Aug 26, 2020
pazz pushed a commit that referenced this issue Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants