Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.15.16 #274

Merged
merged 12 commits into from
Apr 19, 2024
Merged

v0.15.16 #274

merged 12 commits into from
Apr 19, 2024

Conversation

daveshanley
Copy link
Member

@daveshanley daveshanley commented Apr 18, 2024

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.62%. Comparing base (26e390b) to head (037f28a).

Files Patch % Lines
index/resolver.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files         162      162           
  Lines       12071    12077    +6     
=======================================
+ Hits        12026    12032    +6     
  Misses         45       45           
Flag Coverage Δ
unittests 99.62% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member Author

For reference, the missing line is actually covered by the test as it executes, for some reason the coverage tool is not picking it up, but the code does run, it's what caused a regression in the first place.

lesson: only place to much trust in tooling.

@daveshanley daveshanley merged commit b4b24a0 into main Apr 19, 2024
3 of 4 checks passed
@daveshanley daveshanley deleted the v0.15.16 branch April 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant