Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin DigitalOcean spec index test to a specific commit hash #296

Merged
merged 1 commit into from
May 24, 2024

Conversation

martinsirbe
Copy link
Contributor

@martinsirbe martinsirbe commented May 24, 2024

This PR addresses a failing test caused by changes in the upstream repository digitalocean/openapi. The test depended on the number of files in the specification directory, causing it to break whenever files were added or removed. This fix pins the DigitalOcean spec index test to a specific commit hash to ensure consistent test results.

Impact

  • Stability: Tests will no longer break due to changes in the number of files in the upstream repository.
  • Reliability: Ensures consistent and predictable test outcomes.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (382557c) to head (1c73d69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   99.65%   99.63%   -0.02%     
==========================================
  Files         162      162              
  Lines       16101    16101              
==========================================
- Hits        16045    16043       -2     
- Misses         51       53       +2     
  Partials        5        5              
Flag Coverage Δ
unittests 99.63% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member

Thank you!

@daveshanley daveshanley merged commit 711da3b into pb33f:main May 24, 2024
3 of 4 checks passed
@martinsirbe martinsirbe deleted the fix-failing-test branch May 24, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants