Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed new unthemed elements in 5.2.0 workspace #201

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fixed new unthemed elements in 5.2.0 workspace #201

merged 2 commits into from
Oct 18, 2022

Conversation

chotaire
Copy link
Contributor

@chotaire chotaire commented Oct 17, 2022 •
edited
Loading

Fixed unthemed elements in administrative workspace, introduced in 5.2.0.

This affected the following pages:

  • Administration -> Workspace -> Users
  • Administration -> Workspace -> Rooms
  • Administration -> Workspace -> Invites
  • Administration -> Workspace -> View Logs
  • Administration -> Workspace -> Custom Sounds
  • Administration -> Workspace -> Email Inboxes
  • Administration -> Workspace -> Custom Emoji
  • Administration -> Workspace -> Integrations
  • Administration -> Workspace -> Oauth Applications
  • Administration -> Workspace -> Custom User Status
  • Administration -> Workspace -> Permissions
  • Administration -> Workspace -> Settings (element surround search bar when scrolling down)
  • My Account -> Personal Access Tokens

This fixes #200. It is recommended to merge #196 and #198 for additional fixes throughout administrative workspace.

@chotaire chotaire mentioned this pull request Oct 17, 2022
Closed
@chotaire chotaire changed the title Fixed new elements in 5.2.0 workspace Fixed new unthemed elements in 5.2.0 workspace Oct 17, 2022
@paulchen
Copy link
Contributor

I just tried out the changes from this pull request. Looks good.

@pbaity pbaity merged commit e998ca1 into pbaity:master Oct 18, 2022
@chotaire chotaire deleted the 5.2.0-multi branch October 18, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbaity pbaity pbaity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multitude of pages now have unthemed elements in 5.2.0
3 participants
@chotaire @paulchen @pbaity