Fixed Windows ISO downloads #42
Conversation
|
Just specifying: while the referer contains 'windows11', it does indeed work for Windows 10 and 8.1 as well. |
| @@ -801,7 +801,7 @@ function Get-Windows-Download-Links([int]$SelectedVersion, [int]$SelectedRelease | |||
|
|
|||
| try { | |||
| $Is64 = [Environment]::Is64BitOperatingSystem | |||
| $r = Invoke-WebRequest -Method Post -UseBasicParsing -UserAgent $UserAgent -WebSession $Session $url | |||
| $r = Invoke-WebRequest -Method Post -Headers @{'Referer' = 'https://www.microsoft.com/software-download/windows11'} -UseBasicParsing -UserAgent $UserAgent -WebSession $Session $url | |||
There was a problem hiding this comment.
Consider using the windows version variable: $WindowsVersions[$SelectedVersion][0][1]
There was a problem hiding this comment.
I don't think we want to do that for now, because https://www.microsoft.com/software-download/windows8.1 is not a valid page, and that's the URL we'd get for 8.1...
As long as Microsoft's server don't seem to care about the version, using window11 should be good enough.
There was a problem hiding this comment.
Agree with that KISS approach even though this edge case with 8.1 / windows8ISO would be easily handlebar.
|
This was a partial fix which, while helpful, caused some issues for users of Windows 7 SP1 systems. The full-fix, which provides backward-compatibility with Windows 7, can seen in this commit: |
Fix for issue #41, the request now requires the Referer to be set properly.