Change to a more performant system test setup #27
Conversation
|
|
||
| # Configure bundler | ||
| ENV LANG=C.UTF-8 \ | ||
| BUNDLE_JOBS=4 \ |
There was a problem hiding this comment.
I have 8 cores and since bundler now handles that automatically in newer versions, there is no need to limit me to 4 simultaneous downloads.
|
|
||
| sidekiq: | ||
| <<: *backend | ||
| command: bundle exec sidekiq -C config/sidekiq.yml | ||
|
|
||
| postgres: | ||
| image: postgres:13 | ||
| image: postgres:13-alpine |
There was a problem hiding this comment.
Way smaller in size which I believe is fine for everything except the app. Preferably I'd use alpine all the way (I have slow internet).
| @@ -86,7 +93,7 @@ services: | |||
| interval: 5s | |||
|
|
|||
| redis: | |||
| image: "redis:6.2.5-buster" | |||
| image: redis:6.2.6-alpine | |||
There was a problem hiding this comment.
Same here with the download size. Saves me a ton of time when I've cleared up all lingering docker images.
| @@ -5,6 +5,7 @@ | |||
| "requires": true, | |||
| "packages": { | |||
| "": { | |||
| "name": "app", | |||
There was a problem hiding this comment.
npm added this on its own
| Capybara.server_port = 3000 | ||
| } | ||
| end | ||
| Capybara.server_host = "0.0.0.0" |
There was a problem hiding this comment.
I had some problems with the IPSocket. I use both LAN and Wi-Fi so it gets messed up when switching around. I figured it is better to just use 0.0.0.0
| end | ||
|
|
||
| # Drop #debug anywhere in a test to open a Chrome inspector and pause the execution | ||
| def debug(*args) |
There was a problem hiding this comment.
This one is really useful to me when debugging sometimes.
There was a problem hiding this comment.
Yeah, would love to use this!
| @@ -14,7 +14,7 @@ | |||
| begin | |||
| # Silence NPM build output | |||
| $stdout.reopen(File.new("/dev/null", "w")) | |||
| system("npm build") | |||
| system("npm run build") | |||
There was a problem hiding this comment.
The command was broken, I know you are changing to CSS bundling and JS bundling but the tailwind-build.css was never built when I tested this.
|
Awesome @mhenrixon. Was on my list to move to cuprite, definitly interested! Checking this locally now, since I had some challenges making cuprite work on Docker with M1. |
| image: seleniarm/standalone-firefox:4.0.0-beta-1-20210215 | ||
| volumes: | ||
| - /dev/shm:/dev/shm | ||
| image: browserless/chrome |
There was a problem hiding this comment.
This image is not working with Docker on M1. Chrome and Docker on M1 is not fixed yet :(
There was a problem hiding this comment.
Ah the M1 situation, I'll see about alternatives then. Thanks for the feedback.
There was a problem hiding this comment.
The latest version (released yesterday) had something about ARM in the change notes.
Haven't had time to dig in detail but maybe soon...
There was a problem hiding this comment.
There was a problem hiding this comment.
I'll bump the image and address the other feedback tomorrow.
There was a problem hiding this comment.
Oh, awesome! That would be awesome to use!
| RSpec.configure do |config| | ||
| # Add #dom_id support | ||
| config.include ActionView::RecordIdentifier, type: :system | ||
| config.include BetterRailsSystemTests, type: :system | ||
| config.include CapybaraInlineScreenshot::Minitest, type: :system |
There was a problem hiding this comment.
would this work for the RSpec setup we have here? I'm exploring minitest as a default, but not there yet :)
There was a problem hiding this comment.
Gah sloppy paste 🤪 I was confused about setting all this up for mini test (not my preference) at work.
Personally I am an avid RSpec user.
There was a problem hiding this comment.
If you are interested I can show case a mini test setup too.
It isn't that different to be honest. Not sure if app templates work with dual setups but I could explore both now that I know how to do both.
There was a problem hiding this comment.
I guess the the main reason of a template are the default setups and samples. Might be fun to have a spinoff perhaps with minitest. Right now I would be totally happy with just RSpec setup.
| rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* && \ | ||
| truncate -s 0 /var/log/*log | ||
| truncate -s 0 /var/log/*log && |
There was a problem hiding this comment.
I think && should not be here actually, there is nothing after it.
|
Thanks again @mhenrixon, I have cherry-picked the Docker related updates in the the js-css builders PR that just got merged into main. Closing this for now. Will look at using the better-systems specs with Cuprite soon. |
Cuprite is way faster and I really like this setup, let me know if you are interested and I'll adapt the changes so that it works for you.