Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active links are persistent and does not get reset on reload #58

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

sboy99
Copy link
Member

@sboy99 sboy99 commented Jan 29, 2023

Fixes Issue

This pr fixes sidebar reset issue on reload. Sidebar link highlighting is now persisted to respective page.

Closes #54

Changes proposed

  • Added a active link to track active page
  • Active link is set as documentation context
  • Matched active link with file link to highlight the right one

Screenshots

N/A

Note to reviewers

N/A

@sboy99 sboy99 linked an issue Jan 29, 2023 that may be closed by this pull request
1 task
@vercel
Copy link

vercel bot commented Jan 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gitopener-vercel-app ✅ Ready (Inspect) Visit Preview Jan 29, 2023 at 8:24PM (UTC)

Copy link
Member Author

@sboy99 sboy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sboy99 sboy99 merged commit bfc6eae into main Jan 29, 2023
@sboy99 sboy99 deleted the 54-bug-sidebar-reset branch January 29, 2023 20:29
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: On reload sidebar gets reset.
1 participant