Fix creation of empty notes at note root folder when importing Everno…

…te enex files into a note sub-folder for #1212
pbek · May 29, 2019 · 280a62d · 280a62d
1 parent cb47446
commit 280a62d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/dialogs/evernoteimportdialog.cpp b/src/dialogs/evernoteimportdialog.cpp
@@ -542,12 +542,13 @@ void EvernoteImportDialog::importNotes(QString data) {
             Note note = Note();
 //            note.setName(title);
             note.setNoteText(noteText);
+            note.setNoteSubFolderId(noteSubFolder.getId());
 
             // in case the user enabled that the filename can be different
             // from the note name
+            // Attention: may already store the note
             note.handleNoteTextFileName();
 
-            note.setNoteSubFolderId(noteSubFolder.getId());
             note.store();
             note.storeNoteTextFileToDisk();
 

diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
@@ -9748,7 +9748,10 @@ void MainWindow::selectAllNotesInTagTreeWidget() const {
 }
 
 void MainWindow::on_actionImport_notes_from_Evernote_triggered() {
-    EvernoteImportDialog* dialog = new EvernoteImportDialog(this);
+    const QSignalBlocker blocker(noteDirectoryWatcher);
+    Q_UNUSED(blocker);
+
+    auto dialog = new EvernoteImportDialog(this);
     dialog->exec();
 
     if (dialog->getImportCount() > 0) {