Skip to content

Commit

Permalink
removed an unused method and fixed tests
Browse files Browse the repository at this point in the history
  • Loading branch information
pbek committed May 20, 2017
1 parent f9075a0 commit bc8a375
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 17 deletions.
7 changes: 0 additions & 7 deletions doc/scripting/variables.qml
Expand Up @@ -49,17 +49,10 @@ Script {
}
];

property string scriptDirPath;


function init() {
script.registerCustomAction("variablesTest", "Variables test", "Var test", "edit-copy");
doSomethingWithYourVariables();

script.log("scriptDirPath");
script.log(scriptDirPath);
script.log(script.currentNote());
// script.log(id);
}

function doSomethingWithYourVariables() {
Expand Down
9 changes: 0 additions & 9 deletions src/services/scriptingservice.cpp
Expand Up @@ -183,15 +183,6 @@ QList<QVariant> ScriptingService::registerSettingsVariables(
return list;
}

/**
* Returns a script settings variables
*
* @param index
*/
QVariant ScriptingService::getSettingsVariable(QString index) {
_settingsVariables;
}

/**
* Reloads all script components
*/
Expand Down
1 change: 0 additions & 1 deletion src/services/scriptingservice.h
Expand Up @@ -121,5 +121,4 @@ public slots:
void onCustomActionInvoked(QString identifier);
void callCustomActionInvokedForObject(QObject *object, QString identifier);

QVariant getSettingsVariable(QString index);
};
2 changes: 2 additions & 0 deletions tests/unit_tests/testcases/app/app-tests.pri
Expand Up @@ -10,6 +10,7 @@ HEADERS += \
$$APP_SRC_DIR/services/databaseservice.h \
$$APP_SRC_DIR/api/noteapi.h \
$$APP_SRC_DIR/api/tagapi.h \
$$APP_SRC_DIR/api/scriptapi.h \
$$APP_SRC_DIR/services/scriptingservice.h \
$$APP_SRC_DIR/utils/misc.h \
$$APP_SRC_DIR/libraries/piwiktracker/piwiktracker.h \
Expand Down Expand Up @@ -37,6 +38,7 @@ SOURCES += \
$$APP_SRC_DIR/services/databaseservice.cpp \
$$APP_SRC_DIR/api/noteapi.cpp \
$$APP_SRC_DIR/api/tagapi.cpp \
$$APP_SRC_DIR/api/scriptapi.cpp \
$$APP_SRC_DIR/services/scriptingservice.cpp \
$$APP_SRC_DIR/utils/misc.cpp \
$$APP_SRC_DIR/libraries/piwiktracker/piwiktracker.cpp \
Expand Down

0 comments on commit bc8a375

Please sign in to comment.