#2946 spellchecker: remove obsolete checks

CHANGELOG.md

@@ -1,5 +1,9 @@
 # QOwnNotes Changelog
 
+## 24.1.4
+- the spellchecking menu will now also be shown on already selected words
+  (for [#2946](https://github.com/pbek/QOwnNotes/issues/2946))
+
 ## 24.1.3
 - you now can also use <kbd>Ctrl</kbd> + <kbd>=</kbd> to increase the text size
   in the note text edit (for [#2941](https://github.com/pbek/QOwnNotes/issues/2941))

src/widgets/qownnotesmarkdowntextedit.cpp

@@ -1076,30 +1076,22 @@ QMenu *QOwnNotesMarkdownTextEdit::spellCheckContextMenu(QPoint pos) {
     wordSelectCursor.movePosition(QTextCursor::NextCharacter, QTextCursor::KeepAnchor,
                                   selectedWord.size());
 
-    const bool wordIsMisspelled = isMouseCursorInsideWord && spellchecker &&
+    const bool wordIsMisspelled = isMouseCursorInsideWord &&
                                   spellchecker->isActive() && !selectedWord.isEmpty() &&
                                   spellchecker->isWordMisspelled(selectedWord);
 
-    // Use standard context menu for already selected words, correctly spelled
-    // words and words inside quotes.
-    if (!wordIsMisspelled || selectedWordClicked) {
+    if (!wordIsMisspelled) {
         return nullptr;
     }
 
     if (!selectedWordClicked) {
         // If the user clicked on a misspelled word, select that word.
-        if (wordIsMisspelled) {
-            setTextCursor(wordSelectCursor);
-        }
-        // If the user clicked somewhere else, move the cursor there.
-        else {
-            setTextCursor(cursorAtMouse);
-        }
+        setTextCursor(wordSelectCursor);
         cursor = textCursor();
     }
 
-    // create the suggestion menu
-    QMenu *menu = new QMenu(this);
+    // Create the suggestion menu
+    auto *menu = new QMenu(this);
     // Add the suggestions to the menu
     const QStringList reps = spellchecker->suggestionsForWord(selectedWord, cursor, 8);
     if (reps.isEmpty()) {