Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Mermaid #132

Closed
mtompkins opened this issue Apr 9, 2016 · 13 comments
Closed

Enhancement: Mermaid #132

mtompkins opened this issue Apr 9, 2016 · 13 comments
Labels
Type: Feature adds functionality

Comments

@mtompkins
Copy link

Great app. Love the owncloud integration.
Please consider adding Mermaid to your solution for some out-of-the-box diagramming.

Cheers

@pbek
Copy link
Owner

pbek commented Apr 9, 2016

Thank you for your kind words!

The library from the link you sent me only works in the web. Is there something that works on the desktop (C++ Qt) too?

@pbek pbek added the Type: Feature adds functionality label Apr 9, 2016
@mtompkins
Copy link
Author

I was hoping you might be able to integrate the cli component from that source. I also wasn't sure if your markdown rendering engine might support .js. I guess with such standards like highlight.js not integrated I should have concluded that wasn't the case.

Here is the link to the webpage with more integration information if you haven't had a look. http://knsv.github.io/mermaid/

I'm not sure if the cli or API is an option for you.

@pbek
Copy link
Owner

pbek commented Apr 9, 2016

Mermaid relies on Javascript (also uses the D3 library). The "markdown to html" converter QOwnNotes uses just converts markdown to simple html. QOwnNotes doesn't need a Webkit browser to view that.

@pbek
Copy link
Owner

pbek commented Apr 9, 2016

I'm not sure what the CLI version does or needs (I guess node,js)... We can't depend on that everyone has it installed.

@mtompkins
Copy link
Author

The following Github project CuteMarkEd is a QT / C++ app that makes use of mermaid If you find the motivation, perhaps you can have a look at the source to see how it is using the component.

HTH

@pbek
Copy link
Owner

pbek commented Apr 15, 2016

Thank you for the reference. As I can see they are not using any highlighting in the editor, but the generator in a (I guess full-WebKit) browser widget. That's an option but will increase the packages for Windows and OS X dramatically. If QOwnNotes will get a full browser built inside in the future I will consider Mermaid integration.

@pbek
Copy link
Owner

pbek commented Sep 27, 2016

I will close this issue until there is a full blown browser as preview in QOwnNotes.

@pbek pbek closed this as completed Sep 27, 2016
@SeriousM
Copy link

SeriousM commented Nov 9, 2017

I will close this issue until there is a full blown browser as preview in QOwnNotes.

Is that now the case?

@pbek
Copy link
Owner

pbek commented Nov 9, 2017

Is that now the case?

no, it isn't

@e-alfred
Copy link

it would be awesome to have Mermaid.js support now that the Nextcloud Markdown editor supports it:

https://github.com/icewind1991/files_markdown#create-graph-using-mermaidjs

@Simarion
Copy link

it would be awesome to have Mermaid.js support now that the Nextcloud Markdown editor supports

Hi, as though I'd love to see a support for mermaid as well, I don't think it works that way. If I understand pbek correctly, markdown is just converted to html.

Mermaid needs a (webkit) browser to render the html and that's not 'on board'. Although: it looks like the webkid widget is on the roadmap...

BTW thx for the worderful work pbek!

@pbek
Copy link
Owner

pbek commented Mar 14, 2018

@Simarion thank you for your kind words and yes, a fully fledged browser is needed.

@pbek
Copy link
Owner

pbek commented Oct 17, 2021

Maybe you want to look for mermaid in the script repository, added by qownnotes/scripts#135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature adds functionality
Projects
None yet
Development

No branches or pull requests

5 participants