New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backticks are not filtered in navigation list #2791
Comments
Hi, I made a mistake in assuming bold and italic were being stripped out. My eyes were deceiving me. The behaviour is indeed consistent for all markup. My apologies for that. However: I don't see the logic in displaying markup as raw markdown in the navigation panel. It is quite distracting, IMHO a navigation list of plain text makes more sense to me. Would it be possible to make this optional? |
Do you consider using code block in headlines "good-practice"? I don't know if I've seen anyone doing that. Would also would look ugly when you link to a headline... And it possibly would be hard on the CPU of slower computers if a Markdown parser would be fired up a few 100 times for a few 100 headlines each time something changes in the note. 🤔 |
Opinions, @Waqar144? |
We should only strip them out if we can render it according to the markdown syntax. Otherwise it can be misleading imo |
Yes, good point. We still would need to interpret the headings, "kind of"... Otherwise, we would remove single |
I use it all the time in technical notes. When referring to host names for example I prefer these to be indicated by a |
Dunno, those Wikis don't use Markdown by default, don't they? |
No, they don't. Most wiki have their own markup language with often commonalities. I just the example for the sake of a comparison only. For me this is not a major issue, consider it a nice to have for the future. IMHO, it makes sense to see the markup in the navigation panel when working in an edit layout. Likewise, it would make sense to show a rendered navigation panel when the app is in a preview-only mode. I am not sure how to resolve this consistently as you can have an edit & preview panel in the same workspace of course. I prefer to keep them separate to save screen space. |
There is no "preview only mode"... Workspaces are complete free to generate. I wanted to try to strip the characters, but it's not easy to do that without stripping too many, so one would need to write a pseudo Markdown parser to only strip those of formattings and then strip the correct white spaces between the words, like in: ## test * test
## test ~ test |
23.6.5
There now is a new release, could you please test it and report if it works for you? |
Hi, I installed the new release and it looks perfect to me. Many thanks for the fix! Perhaps to consider for other users: making this feature optional or not. For me it would certainly be the default to have the markup filtered in the navigation panel. |
Thank you for testing! |
Expected behaviour
When using backticks in any markdown header line, the resulting preview of the navigation list does not filter the backticks. Other markup like italic or bold IS filtered out correctly in preview mode
Actual behaviour
Steps to reproduce
See screenshots:
edit mode:
preview mode:
The text was updated successfully, but these errors were encountered: