Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT] Bookmarks/Shortcuts get lost when closing QOwnNotes #2933

Closed
Mr-Rayman opened this issue Dec 28, 2023 · 7 comments
Closed

[SUPPORT] Bookmarks/Shortcuts get lost when closing QOwnNotes #2933

Mr-Rayman opened this issue Dec 28, 2023 · 7 comments
Assignees
Labels
Milestone

Comments

@Mr-Rayman
Copy link

Mr-Rayman commented Dec 28, 2023

When closing QOwnNotes all assigned bookmarks get lost. On reopening, none of the shortcuts to bookmarks work anymore.
Thus, bookmarks work just within one session which isn't ideal. Is this expected behavior or a bug?

From my point of view it would be perfect, if bookmarks are saved across sessions (e.g. in QOwnNotes sqlite database). Also it would be nice to have a little visualization of the bookmark positions at the left or right border of the QOwnNotes editor.

I'm refering to most recent QOwnNotes version 23.12.4 on Windows.

Thanks!

@pbek
Copy link
Owner

pbek commented Dec 28, 2023

Can you please post the output from the debug settings (see issue template).
And is there any useful log output if you enable the log panel (see Window / Panels)? Please make sure you also enable debug logging in the log panel (by right-clicking on the panel and selecting Debug in Options).

@Mr-Rayman
Copy link
Author

Please see the debug information attached. I checked the log output. The log ouput is normal while setting and jumping to bookmarks, (I use the German translation, so it's 'Note position set as bookmark 1' and 'Jumped to bookmark 1'). After closing and re-opening QOwnNotes and pressing 'Ctrl+1' nothing happens and nothing is reported to the log output (other unrelated debug messages are reported okay).

Just for my interest: What is the expected behavior? Are bookmarks actually saved to the QOwnNotes database and restored everytime QOwnNotes is opened?

QOwnNotes Debug Information.txt

@pbek
Copy link
Owner

pbek commented Dec 28, 2023

Ah, you meant bookmarks to note positions, not browser bookmarks. They are not persisted, didn't make a lot of sense to me back then, because the whole note folder could change while the app is closed, but maybe I'll persist them in the future.

@pbek pbek added Type: Feature adds functionality Importance: Low and removed Type: Support labels Dec 28, 2023
@pbek pbek self-assigned this Dec 28, 2023
@pbek
Copy link
Owner

pbek commented Dec 28, 2023

23.12.5

  • note bookmarks will now be persisted and restored when the application starts
    (for #2933)

@pbek pbek added this to the 23.12.5 milestone Dec 28, 2023
@pbek
Copy link
Owner

pbek commented Dec 28, 2023

There now is a new release, could you please test it and report if it works for you?

@Mr-Rayman
Copy link
Author

There now is a new release, could you please test it and report if it works for you?

Perfect! Thank you very much for the fast implementation. I've tested and it works fine! That saves me a lot of navigation-clicks during my daily work!

I have my note folder and it's files (notes.sqlite ..) on a network-share that is being used by different computers (work, home, ..). From what I see the note bookmarks are saved locally on each computer and not beside the notes on the network-share, so each computer saves it's own bookmark positions. That is still fine by me, as the persistence is the most important thing :-)

@pbek
Copy link
Owner

pbek commented Dec 29, 2023

Great, thank you for testing!
Yes, they are stored as normal settings.

@pbek pbek closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants