New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linktext is hard to read in dark-mode #597

Closed
noudAndi opened this Issue May 30, 2017 · 16 comments

Comments

Projects
None yet
3 participants
@noudAndi

noudAndi commented May 30, 2017

Expected behaviour

Links should have another color than dark-blue, when using the dark-mode

Actual behaviour

The Link text is dark blue and a bit hard to read ;)

Steps to reproduce

Have a look the the Changelog in the QOwnNotes Client

changelog-darkmode

Output from the debug section in the settings dialog

Relevant log output (you have to enable enable the log widget)

==> THANKS for this awesome Tool!! I'm loving it! 😄

@pbek

This comment has been minimized.

Owner

pbek commented May 30, 2017

Thank you for your kind words. :)

Are you talking about the update dialog specifically?
You didn't post your debug settings, did you manually turn on the dark mode in QOwnNotes?
For me the colors in the preview are orange, not dark blue.

And in the update dialog the link color is a light blue. Those colors are taken from your operating system's configuration.

@noudAndi

This comment has been minimized.

noudAndi commented May 31, 2017

Hi,

thanks for your reply.

I'm using the dark Mode setting, which is offered in the Configuration "Settings -> Interface -> Enable dark mode"

All links within QOwnNotes are like the one in the screenshot.

Here are my Debug-Information (I deleted some personal information)

QOwnNotes Debug Information

General Info

Current Date: Mi Mai 31 10:00:21 2017
Version: 17.05.14
Build date: May 30 2017
Build number: 3031
Platform: windows
Operating System: Windows 10
Build architecture: i386
Current architecture: x86_64
Release: AppVeyor
Qt Version (build): 5.7.1
Qt Version (runtime): 5.7.1
Portable mode: yes
Settings path / key: C:/Users/my_username/Downloads/QOwnNotes/Data/PBE/QOwnNotes.ini
Application database path: C:\Users\my_username\Downloads\QOwnNotes\Data\QOwnNotes.sqlite
Application arguments: C:\Users\my_username\Downloads\QOwnNotes\QOwnNotes.exe, --after-update, C:\Users\my_username\AppData\Local\Temp\QOwnNotes-P11044-updater.bat, --portable
Qt Debug: 0
Locale (system): de_DE
Locale (interface): empty
Icon theme: breeze-dark-qownnotes
Notes in current note folder: 438
Enabled scripts: 0

Server Info

serverUrl: https://my.server.de:8443
appIsValid: yes
notesPathExists: yes
serverVersion: 11.0.3.2
appVersion: 17.5.0

Note folders

currentNoteFolderId: 1

Note folder Standard

id: 1
isCurrent: yes
activeTagId: -1
localPath: C:\Users\my_username\Downloads\QOwnNotes\Data\..\..\..\Nextcloud\Notes
remotePath: Notes
isShowSubfolders: no
isUseGit: no
activeNoteSubFolder name: empty
database file: C:\Users\my_username\Downloads\QOwnNotes\Data\..\..\..\Nextcloud\Notes\notes.sqlite

Note folder MacroCom

id: 2
isCurrent: no
activeTagId: 0
localPath: C:\Users\my_username\Downloads\QOwnNotes\Data\..\..\..\Documents\QownNotes
remotePath: empty
isShowSubfolders: no
isUseGit: no
activeNoteSubFolder name: empty
database file: C:\Users\my_username\Downloads\QOwnNotes\Data\..\..\..\Documents\QownNotes\notes.sqlite

Enabled scripts

Settings

AboutDialog/geometry: <binary data>
ActiveNoteHistoryItem: empty
Debug/fakeOldVersionNumber: false
Debug/fileLogging: false
Editor/CurrentSchemaKey: EditorColorSchema-cdbf28fc-1ddc-4d13-bb21-6a4043316a2f
Editor/autoBracketClosing: true
Editor/autoBracketRemoval: true
LastUpdateCheck: 2017-05-31T10:00:10
MainWindow/geometry: <binary data>
MainWindow/mainToolBar.iconSize: 24
MainWindow/menuBarGeometry: <binary data>
MainWindow/noteTextEdit.code.font: Courier New,9,-1,2,50,0,0,0,0,0
MainWindow/noteTextEdit.font: MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.code.font: Courier New,9,-1,2,50,0,0,0,0,0
MainWindow/noteTextView.font: MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.rtl: false
MainWindow/showNotesFromAllNoteSubFolders: true
NoteDiffDialog/geometry: <binary data>
PiwikClientId: <hidden>
SettingsDialog/geometry: <binary data>
SettingsDialog/mainSplitterState: <binary data>
ShowSystemTray: false
UpdateDialog/geometry: <binary data>
WelcomeDialog/geometry: <binary data>
acceptAllExternalModifications: false
allowDifferentNoteFileName: false
allowOnlyOneAppInstance: false
appMetrics/disableAppHeartbeat: false
appMetrics/disableTracking: false
appMetrics/notificationShown: true
cryptoKey: <hidden>
currentNoteFolderId: 1
currentWorkspace: b76f2e69-e678-4357-a908-306795682df0
customNoteFileExtensionList: empty
darkMode: true
darkModeColors: true
darkModeTrayIcon: true
defaultNoteFileExtension: md
demoNotesCreated: true
disableAutomaticUpdateDialog: false
dockWasInitializedOnce: true
externalEditorPath: empty
gitCommitInterval: 30
gitExecutablePath: empty
gitLogCommand: empty
ignoreAllExternalModifications: true
ignoreAllExternalNoteFolderChanges: false
imageScaleDown: false
imageScaleDownMaximumHeight: 1024
imageScaleDownMaximumWidth: 1024
insertTimeFormat: empty
interfaceLanguage: empty
internalIconTheme: false
itemHeight: 15
markdownHighlightingEnabled: true
networking/ignoreSSLErrors: false
networking/proxyType: 2
noteSaveIntervalTime: 10
noteSubfoldersPanelDisplayAsFullTree: false
noteSubfoldersPanelHideSearch: false
noteSubfoldersPanelOrder: 0
noteSubfoldersPanelShowFullPath: false
noteSubfoldersPanelShowRootFolderName: false
noteSubfoldersPanelSort: 0
notesPanelOrder: 0
notesPanelSort: 1
notesPath: ../../../Nextcloud/Notes
notifyAllExternalModifications: false
ownCloud/password: <hidden>
ownCloud/serverUrl: https://my.server.de:8443
ownCloud/supportEnabled: true
ownCloud/todoCalendarBackend: 3
ownCloud/todoCalendarCalDAVPassword: <hidden>
ownCloud/todoCalendarCalDAVServerUrl: empty
ownCloud/todoCalendarCalDAVUsername: empty
ownCloud/todoCalendarEnabledList: empty
ownCloud/todoCalendarEnabledUrlList: empty
ownCloud/todoCalendarUrlList: empty
ownCloud/userName: andreas
previousWorkspace: 18103ce0-5a25-46e4-94dd-d28f6c17be65
recentNoteFolders: C:/Users/my_username/Downloads/QOwnNotes/Data/../../../Documents/QownNotes, C:/Users/my_username/Downloads/QOwnNotes/Data/D:/Daten/MacQownNotes
restoreCursorPosition: true
savedSearches/noteFolder-1: graylog2 Cheatseet, Bash Cheatsheet, unattended upgrade, SMB Cheatsheet, Openssl Cheatsheet, ssh CheatSheet, Icinga 2 Director, Git Cheat Sheet, Perl Cheatsheet, jira, Apache Reverse Proxy, Graphite - Carbon, editor, php pecl, Docker, mysq, insserv, mod_rewrite, PHP - FPM, Node.js - Performance Settings, Microsoft SQL - MSSQL Cheat Sheet, Bash stat
showMenuBar: true
showStatusBar: true
skipVersion: 17.05.1
tagWasAddedToNote: true
tagsPanelHideSearch: false
tagsPanelOrder: 0
tagsPanelSort: 0
toolbar/1/items: action_New_note, action_Find_note, action_Remove_note, action_Open_note_in_external_editor, , action_Back_in_note_history, action_Forward_in_note_history, , action_Find_text_in_note, actionReplace_in_current_note, , actionShow_versions, actionShow_trash, actionShare_note, , actionOpen_List
toolbar/1/name: mainToolBar
toolbar/1/title: Hauptsymbolleiste
toolbar/2/items: actionFormat_text_bold, actionFormat_text_italic, actionStrike_out_text, actionInsert_code_block, actionInsert_block_quote
toolbar/2/name: formattingToolbar
toolbar/2/title: Formatierungs-Werkzeugleiste
toolbar/3/items: actionInsert_Link_to_note, actionInsert_image, actionInsert_current_time
toolbar/3/name: insertingToolbar
toolbar/3/title: Einfügen-Werkzeugleiste
toolbar/4/items: action_Encrypt_note, actionEdit_encrypted_note, actionDecrypt_note
toolbar/4/name: encryptionToolbar
toolbar/4/title: Werkzeugleiste Verschlüsselung
toolbar/5/items: actionWorkspaceComboBox, actionStore_as_new_workspace, actionRemove_current_workspace, actionRename_current_workspace, actionSwitch_to_previous_workspace, actionUnlock_panels, , actionToggle_distraction_free_mode, action_Increase_note_text_size, action_Decrease_note_text_size, action_Reset_note_text_size
toolbar/5/name: windowToolbar
toolbar/5/title: Fenster-Werkzeugleiste
toolbar/6/items: action_Quit
toolbar/6/name: quitToolbar
toolbar/6/title: Beenden - Symbolleiste
toolbar/size: 6
useUNIXNewline: false
workspace-18103ce0-5a25-46e4-94dd-d28f6c17be65/name: Vollständig
workspace-18103ce0-5a25-46e4-94dd-d28f6c17be65/noteSubFolderDockWidgetVisible: true
workspace-18103ce0-5a25-46e4-94dd-d28f6c17be65/windowState: <binary data>
workspace-b76f2e69-e678-4357-a908-306795682df0/name: Minimal
workspace-b76f2e69-e678-4357-a908-306795682df0/noteSubFolderDockWidgetVisible: true
workspace-b76f2e69-e678-4357-a908-306795682df0/windowState: <binary data>
workspaces: 18103ce0-5a25-46e4-94dd-d28f6c17be65, b76f2e69-e678-4357-a908-306795682df0

System environment

ALLUSERSPROFILE: C:\ProgramData
APPDATA: C:\Users\my_username\AppData\Roaming
CommonProgramFiles: C:\Program Files (x86)\Common Files
CommonProgramFiles(x86): C:\Program Files (x86)\Common Files
CommonProgramW6432: C:\Program Files\Common Files
COMPUTERNAME: MAC-BAUER-P1
ComSpec: C:\Windows\system32\cmd.exe
destination: C:\Users\my_username\Downloads\QOwnNotes
EmpirumServer: MHK-PWM-S1.mhknet.de
FPS_BROWSER_APP_PROFILE_STRING: Internet Explorer
FPS_BROWSER_USER_PROFILE_STRING: Default
GDT-SERVER: CARATAPP01
HOMEDRIVE: C:
HOMEPATH: \Users\my_username
INHOUSE: CARAT
LOCALAPPDATA: C:\Users\my_username\AppData\Local
LOGONSERVER: \\C-DC-S1
NUMBER_OF_PROCESSORS: 8
OS: Windows_NT
Path: C:\ProgramData\Oracle\Java\javapath;C:\Python27\;C:\Python27\Scripts;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\SysWOW64\Empirum;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program Files (x86)\Brackets\command;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\nodejs\;C:\Program Files (x86)\PuTTY\;C:\Program Files\TortoiseGit\bin
PATHEXT: .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
portable: --portable
PROCESSOR_ARCHITECTURE: x86
PROCESSOR_ARCHITEW6432: AMD64
PROCESSOR_IDENTIFIER: Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
PROCESSOR_LEVEL: 6
PROCESSOR_REVISION: 5e03
ProgramData: C:\ProgramData
ProgramFiles: C:\Program Files (x86)
ProgramFiles(x86): C:\Program Files (x86)
ProgramW6432: C:\Program Files
PROMPT: $P$G
PSModulePath: C:\Program Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules
PUBLIC: C:\Users\Public
qownnotesCommand: C:\Users\my_username\Downloads\QOwnNotes\QOwnNotes.exe --after-update C:\Users\my_username\AppData\Local\Temp\QOwnNotes-P11044-updater.bat --portable
SESSIONNAME: Console
source: C:\Users\my_username\AppData\Local\Temp\QOwnNotes-P11044.zip
SystemDrive: C:
SystemRoot: C:\Windows
TEMP: C:\Users\my_username\AppData\Local\Temp
TMP: C:\Users\my_username\AppData\Local\Temp
unzipCommand: C:\Users\my_username\AppData\Local\Temp\QOwnNotes-P11044-unzip.exe -o C:\Users\my_username\AppData\Local\Temp\QOwnNotes-P11044.zip -d C:\Users\my_username\Downloads\QOwnNotes
unzipExecutable: C:\Users\my_username\AppData\Local\Temp\QOwnNotes-P11044-unzip.exe
USERDNSDOMAIN: MYDOMAIN
USERDOMAIN: MYDOMAIN
USERDOMAIN_ROAMINGPROFILE: MYPROFILE
USERNAME: MyUsername
USERPROFILE: C:\Users\my_username
VBOX_MSI_INSTALL_PATH: C:\Program Files\Oracle\VirtualBox\
windir: C:\Windows

@noudAndi noudAndi changed the title from Enhancement: Linktext is hard to read in dark-mode to Linktext is hard to read in dark-mode May 31, 2017

@pbek

This comment has been minimized.

Owner

pbek commented May 31, 2017

Can you please send a screenshot of the note preview?

@pbek

This comment has been minimized.

Owner

pbek commented May 31, 2017

For me the links in the preview are orange in dark mode...

@noudAndi

This comment has been minimized.

noudAndi commented May 31, 2017

Hi,
the links in the markup text are orange. They are all working fine!

image

I'm talking only about the links, which are for example in the Update Window or in the configuration.

Here is another example:

image

@pbek

This comment has been minimized.

Owner

pbek commented May 31, 2017

Your operating system decides the color of those links. It seems that your OS isn't "dark-mode enabled". I'll see if I can do something about that.

@pbek pbek added the enhancement label May 31, 2017

@noudAndi

This comment has been minimized.

noudAndi commented May 31, 2017

OK, thanks a lot!

@pbek

This comment has been minimized.

Owner

pbek commented May 31, 2017

17.06.0

  • more styling for links and <kbd> tags in various labels and text-browsers
    was now done to fix problems with operating systems that don't set default
    colors fitting to be used in dark mode

It was a big pain to achieve this. 😓 Please let me know if you see any more links with too dark color.

@pbek pbek added this to the 17.06.0 milestone May 31, 2017

@pbek

This comment has been minimized.

Owner

pbek commented May 31, 2017

There now is a new release, could you please test it and report if it works for you?

@noudAndi

This comment has been minimized.

noudAndi commented May 31, 2017

Works like a charm!! 🏆

grafik

Thanks again for your efforts!

@pbek

This comment has been minimized.

Owner

pbek commented May 31, 2017

Thank you for testing!

@pbek pbek closed this May 31, 2017

@EvEvans

This comment has been minimized.

EvEvans commented Nov 8, 2017

This issue seems only partly resolved. Links appear orange on some pages:
screenshot - 08-11-17 14_15_21
and
screenshot - 08-11-17 14_15_42

But links appear blue on others:
screenshot - 08-11-17 14_15_58
and
screenshot - 08-11-17 14_16_07

@pbek

This comment has been minimized.

Owner

pbek commented Nov 8, 2017

Thank you for the feedback. Mine have an other color, seems like those colors are decided by the operating system / desktop environment. I will take a look at those... Did you find any more, @Ev-Evans?

@EvEvans

This comment has been minimized.

EvEvans commented Nov 8, 2017

I just went through all screens I could find. Other than the two already mentioned
I found one more location: the script repository. The links in the descriptions of all different scripts are blue. All other links I encountered were orange.

screenshot - 08-11-17 15_20_42

Thanks for your work!

@pbek

This comment has been minimized.

Owner

pbek commented Nov 12, 2017

I also fixed the colors in the script repository...

17.11.1

  • fixed a lot of link colors in the user interface in dark mode for desktop
    environments that are forcing a to dark link color
@pbek

This comment has been minimized.

Owner

pbek commented Nov 12, 2017

There now is a new release, could you please test it and report if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment