Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pdf export with checkboxes #235 #1155

Merged
merged 1 commit into from Feb 21, 2019

Conversation

liulex
Copy link
Contributor

@liulex liulex commented Feb 20, 2019

But I cannot reproduce this:

for me all checkboxes are visible, but unchecked

Anyway, please test with this patch.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 2.717% when pulling 6961d99 on liulex:feature/pdf-export-with-checkboxes into 8d7ce82 on pbek:develop.

@pbek
Copy link
Owner

pbek commented Feb 21, 2019

Thank you for your quick implementation!

For some reason I can only see unchecked checkboxes, the checked ones are not present.

Checkbox Test.pdf

@pbek pbek merged commit 040c9dc into pbek:develop Feb 21, 2019
@liulex
Copy link
Contributor Author

liulex commented Feb 21, 2019

It should be a font issue. Copy this character
default
and paste it into browser, you will get ☑.

@pbek
Copy link
Owner

pbek commented Feb 22, 2019

Now, that is funny. I can see them on Manjaro, but not on KDE Neon. Could really be a font issue.

@pbek
Copy link
Owner

pbek commented Feb 22, 2019

Anyway, great work! I love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants