Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falsely highlighting of links in 4-Spaces fence code blocks #199

Closed
pbek opened this issue Dec 4, 2023 · 4 comments · Fixed by #200
Closed

Falsely highlighting of links in 4-Spaces fence code blocks #199

pbek opened this issue Dec 4, 2023 · 4 comments · Fixed by #200
Assignees
@tim-gromeyer
Labels
regression

Comments

@pbek
Copy link
Owner

pbek commented Dec 4, 2023

@tim-gromeyer, unfortunately 53c4c598 of #188 did break something else too:

    wget http://google.com

http://google.com is now highlighted as link, but it shouldn't.

Originally posted by @pbek in #188 (comment)
@pbek pbek mentioned this issue Dec 4, 2023
Merged
@tim-gromeyer
Copy link
Contributor

It's a link, so why shouldnt it be highlighted? But if you want, as far as I can remember this is pretty easy to change

@pbek
Copy link
Owner Author

pbek commented Dec 4, 2023

I haven't seen links being highlighted in 4-Spaces fence code blocks so far... GitHub also doesn't highlight them, for example. And qmarkdowntextedit also doesn't highlight them in backtick code blocks...

@pbek pbek added the regression label Dec 4, 2023
@tim-gromeyer
Copy link
Contributor

Okay, I'll look into that tomorrow.

Can you give me some more examples where it highlights when it shouldn't and vice versa?

@pbek
Copy link
Owner Author

pbek commented Dec 5, 2023

That was the only thing that was reported so far.

tim-gromeyer added a commit to tim-gromeyer/qmarkdowntextedit that referenced this issue Dec 6, 2023
@tim-gromeyer
Falsely highlighting of links in code blocks (closes pbek#199)
14f2576
@tim-gromeyer tim-gromeyer mentioned this issue Dec 6, 2023
Merged
@pbek pbek closed this as completed in #200 Dec 6, 2023
@pbek pbek changed the title Falsely highlighting of links in code blocks Falsely highlighting of links in 4-Spaces fence code blocks Dec 6, 2023
pbek added a commit to pbek/QOwnNotes that referenced this issue Dec 7, 2023
@pbek
pbek/qmarkdowntextedit#199 deps: update qmarkdowntextedit library
b1bd79b
@pbek pbek mentioned this issue Dec 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-gromeyer tim-gromeyer

Labels
regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Falsely highlighting of links in code blocks tim-gromeyer/qmarkdowntextedit
2 participants
@pbek @tim-gromeyer