Add initial support for Markdown #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbelokon
reviewed
Sep 20, 2023
src/parser.js
Outdated
Comment on lines
45
to
61
| if (line.startsWith("# ")) { | ||
| var slicedLine = line.slice(2); | ||
| return `<h1>${slicedLine}</h1>`; | ||
| } else if (line.startsWith("## ")) { | ||
| var slicedLine = line.slice(3); | ||
| return `<h2>${slicedLine}</h2>`; | ||
| } else if (line.startsWith("### ")) { | ||
| var slicedLine = line.slice(3); | ||
| return `<h3>${slicedLine}</h3>`; | ||
| } else if (line.startsWith("_") && line.endsWith("_")) { | ||
| var slicedLine = line.slice(1); | ||
| slicedLine = slicedLine.slice(0, -1); | ||
| return `<i>${slicedLine}</i>`; | ||
| } else { | ||
| return `<p>${line}</p>`; | ||
| } | ||
| }) |
There was a problem hiding this comment.
I would like you to refer from using var since it's outdated just use a let and declare it before the line 42.
Is there a way that you can change this part line 54 your are assuming that italics takes the entire line, could you implement it the way that would allow for something like this hello _italic_ hello. I think this regex would help(\*|_)(.*?)\1
There was a problem hiding this comment.
Used 'let' instead of 'var' variable and added regex to find lines in italics as you mentioned.
Please have a look and let me know if it's okay to merge. Thanks
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4