Skip to content

Commit

Permalink
drop testing on jenkins:1.554
Browse files Browse the repository at this point in the history
2 version was introduced in April 2016
  • Loading branch information
pbelskiy committed Jun 24, 2023
1 parent 8127a87 commit b9568d2
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
jenkins-version: ['jenkins:1.554', 'jenkins/jenkins:2.60', 'jenkins/jenkins:2.319']
jenkins-version: ['jenkins/jenkins:2.60', 'jenkins/jenkins:2.319']

services:
jenkins:
Expand Down
7 changes: 0 additions & 7 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ Prerequisites: `docker, tox`
chromium http://localhost:8080 # create admin:admin
tox


Or Jenkins 1.554

::

docker run -d --name jenkins-1.554 --restart always -p 8081:8080 jenkins:1.554

Contributing
------------

Expand Down
5 changes: 0 additions & 5 deletions tests/test_builds.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ async def test_build_exists(jenkins):

@pytest.mark.asyncio
async def test_build_queue_id(jenkins):
version = await jenkins.get_version()
# was introduced default admin with password
if version.major < 2:
pytest.skip('there is problem, probably queue id was not implemented')

async with CreateJob(jenkins) as job_name:
queue_id = await jenkins.builds.start(job_name)
assert queue_id > 0
Expand Down
5 changes: 0 additions & 5 deletions tests/test_jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ async def test_get_job_info(jenkins):

@pytest.mark.asyncio
async def test_copy_job(jenkins):
version = await jenkins.get_version()
if version.major < 2:
# FIXME: need to investigate
pytest.skip('Jenkins version < 2 somehow freezed here')

async with CreateJob(jenkins) as job_name:
job_name_new = job_name + '_new'
await jenkins.jobs.copy(job_name, job_name_new)
Expand Down

0 comments on commit b9568d2

Please sign in to comment.