-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path not correct issue if there is no build parameters #23
Conversation
Hello! Thanks for PR, but here is regression in tests, please fix it. And could you explain problem details? |
@pbelskiy the tests were aborted due to environment variable issue
|
@ttt43ttt I've added token, please rebase now. And please update in description:
|
@ttt43ttt thanks, it's okay now, I will check CI error later |
@ttt43ttt I don't exactly understand the root of the problem, but I read some here (lemurheavy/coveralls-public#1435), and patched github actions file, so rebase please and we will test it. |
@ttt43ttt I've fixed and tested coveralls now for all scenarios. So, please rebase again, now should be okay. PS: BTW you can create same PR for new jenkins library - https://github.com/pbelskiy/ujenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@ttt43ttt thanks for PR! Released under 0.7.4 (https://github.com/pbelskiy/aiojenkins/releases/tag/v0.7.4) You can create same PR for other library - https://github.com/pbelskiy/ujenkins |
when building a job, the job path should be same no matter having parameters or not.