Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path not correct issue if there is no build parameters #23

Merged
merged 7 commits into from
Dec 3, 2021
Merged

Fix path not correct issue if there is no build parameters #23

merged 7 commits into from
Dec 3, 2021

Conversation

ttt43ttt
Copy link
Contributor

@ttt43ttt ttt43ttt commented Nov 29, 2021

when building a job, the job path should be same no matter having parameters or not.

@pbelskiy
Copy link
Owner

Hello! Thanks for PR, but here is regression in tests, please fix it. And could you explain problem details?

@ttt43ttt
Copy link
Contributor Author

@pbelskiy the tests were aborted due to environment variable issue

coveralls.exception.CoverallsException: Running on Github Actions but GITHUB_TOKEN is not set. Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to your step config.

@pbelskiy
Copy link
Owner

@ttt43ttt I've added token, please rebase now. And please update in description:

  1. version of jenkins you using
  2. how do you run build
  3. what do you expect
  4. what you see

aiojenkins/builds.py Outdated Show resolved Hide resolved
aiojenkins/builds.py Show resolved Hide resolved
@pbelskiy
Copy link
Owner

pbelskiy commented Dec 1, 2021

@ttt43ttt thanks, it's okay now, I will check CI error later

@pbelskiy
Copy link
Owner

pbelskiy commented Dec 1, 2021

@ttt43ttt I don't exactly understand the root of the problem, but I read some here (lemurheavy/coveralls-public#1435), and patched github actions file, so rebase please and we will test it.

@pbelskiy pbelskiy self-requested a review December 1, 2021 18:31
@pbelskiy
Copy link
Owner

pbelskiy commented Dec 2, 2021

Hm, that's really strange, that there is some problems with coveralls push on your PR, but on mine okay:
#24

But I've created same change from other account and got same error: #25

@pbelskiy
Copy link
Owner

pbelskiy commented Dec 2, 2021

@ttt43ttt I've fixed and tested coveralls now for all scenarios. So, please rebase again, now should be okay.

PS: BTW you can create same PR for new jenkins library - https://github.com/pbelskiy/ujenkins

Copy link
Owner

@pbelskiy pbelskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pbelskiy pbelskiy merged commit d83dc5e into pbelskiy:master Dec 3, 2021
@pbelskiy
Copy link
Owner

pbelskiy commented Dec 3, 2021

@ttt43ttt thanks for PR! Released under 0.7.4 (https://github.com/pbelskiy/aiojenkins/releases/tag/v0.7.4)

You can create same PR for other library - https://github.com/pbelskiy/ujenkins

@ttt43ttt ttt43ttt deleted the build_job_issue branch December 4, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants