Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with macOS Mojave #72

Merged
merged 4 commits into from
Sep 26, 2018
Merged

Resolve issue with macOS Mojave #72

merged 4 commits into from
Sep 26, 2018

Conversation

johanns
Copy link
Collaborator

@johanns johanns commented Sep 26, 2018

This should also keep compatibility with older versions of the OS and CPU architectures.

@johanns johanns merged commit 973f53f into master Sep 26, 2018
@johanns
Copy link
Collaborator Author

johanns commented Sep 26, 2018

@pbhogan @stakach Please cut a new gem version (I didn't bumped version number).

@tommeier
Copy link

please cut a new version with this ❤️

@nathanjo
Copy link

up+, waiting for this. thanks! (PS: please cut a new gem version)

@tommeier
Copy link

tommeier commented Sep 27, 2018

actually this is having some issues locally - installation works - but any time using it (like assets:precompile) I'm getting cannot find 'scrypt_ext' library (LoadError) on both Mojave systems (and previous OS) (when scrypt installed from github reference)

@johanns
Copy link
Collaborator Author

johanns commented Sep 27, 2018

@tommeier Can you please elaborate on how you're installing it? Are you using rake gem to produce a gem file locally to install, and it's having issues or are referencing the GitHub repo in the Gemfile?

@tommeier
Copy link

tommeier commented Sep 27, 2018

@johanns installing via referenced Github in Gemfile: gem 'scrypt', git: 'https://github.com/pbhogan/scrypt.git'

@johanns
Copy link
Collaborator Author

johanns commented Sep 27, 2018

@tommeier Confirmed, but it isn't an issue that was introduced with this PR/fix. It seems that the native code isn't being compiled when installed through Gemfile reference. Investigating a fix isn't something I can do at the moment, but as a workaround, you can grab and install the unsigned gem file from here: https://github.com/pbhogan/scrypt/releases/tag/3.0.6

@tommeier
Copy link

Thanks @johanns ❤️

@pbhogan
Copy link
Owner

pbhogan commented Sep 27, 2018

I'm currently traveling and don't have my full dev setup with me, but I'll see what I can do to cut a new gem version ASAP.

@pbhogan
Copy link
Owner

pbhogan commented Sep 27, 2018

@stakach Any chance you push a new release? I'd have to make a new certificate to do it since it's using yours.

@pbhogan
Copy link
Owner

pbhogan commented Sep 28, 2018

Okay, since I didn't hear from @stakach, I've made a new cert and pushed 3.0.6 to RubyGems. Hopefully I did it correctly... let me know if it works for y'all. :)

@stakach
Copy link
Collaborator

stakach commented Sep 28, 2018

Sorry, been scuba diving the Galápagos Islands - no connectivity :(

@johanns
Copy link
Collaborator Author

johanns commented Sep 28, 2018

@pbhogan Looks good!

@tommeier
Copy link

works perfectly for me 👍 via bundler too, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants