Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change baseline default of prediction_breakdown() to be consistent with broken() #43

Merged

Conversation

kevinykuo
Copy link
Contributor

This change:

  • Removes the default of the baseline parameter of prediction_breakdown(). This is so that the defaults agree with the underlying breakDown::broken() function. This is a potentially breaking if users were depending on the hardcoded baseline = "Intercept", but I'd argue consistency with broken() should be the expected behavior.

Closes #39

@codecov-io
Copy link

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   89.35%   89.35%           
=======================================
  Files          12       12           
  Lines         263      263           
=======================================
  Hits          235      235           
  Misses         28       28
Impacted Files Coverage Δ
R/single_prediction.R 80% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f5961...3bc75b5. Read the comment docs.

@pbiecek
Copy link
Member

pbiecek commented Aug 27, 2018

Thanks!
This is more consistent.
What worries me is the lack of backward compatibility.
Will add a more direct warning to the NEWS.md

@pbiecek pbiecek merged commit a4c35dd into ModelOriented:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants