Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Bug] Can't unset repoDir parameter in aoptions #176
Comments
|
@pbiecek what do you think about such solution? |
|
Will be better to find some other solution. Here the forceNULL is only to cover one special case. And NULL is not a real value it's lack of value. Maybe we can use the value NA? Or use name like unset instead of forceNULL? The second option is better since the name 'unset' corresponds to the expected behaviour of the function. |
If one would like to unset the
repoDirparameter to beNULLas it is from the start (when thearchivistpackage is loaded), it is impossible because when the second argument ofaoptionsis set toNULLthen this function returns the argument instead of setting this parameter.This functionality is crucial to unset
repoDirwhen one would like to work with GitHub repo after he set Local repo and is usingareadfunction that usesloadFromRepofunction that checks global parameters. I recommend to addforceNULLparameter to theaoptionsfunction. This is the cause of #175