Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Sweave/knitr #180

Closed
pbiecek opened this issue Jan 10, 2016 · 7 comments
Closed

Integration with Sweave/knitr #180

pbiecek opened this issue Jan 10, 2016 · 7 comments
Assignees
Labels

Comments

@pbiecek
Copy link
Owner

pbiecek commented Jan 10, 2016

An use-case with overridden print function for gg class?
Like here: https://github.com/pbiecek/Eseje/blob/master/GamatykaGrafiki.Rmd

@pbiecek pbiecek self-assigned this Jan 10, 2016
@MarcinKosinski
Copy link
Collaborator

is this the same as #74 ? or this is use case for that functionality?

@pbiecek
Copy link
Owner Author

pbiecek commented Jan 10, 2016

imho pin is closely related with github. It takes care about integration with github but do not care if knitr is used or not. And you need to actively point which objects should be archived.

While here we do not need github at all.
We may include links to dropbox repositories/google drive repos or anything that user can implement.
All objects of given class will be archived.

@MarcinKosinski
Copy link
Collaborator

In your example you provide hooks that directs to the object stored on GitHub. Maybe you would like to change the link under the hook that the object would automatically be downloaded (as it is done in alink function, archive (for alink = TRUE) ahistory (for alink = TRUE))?

@pbiecek
Copy link
Owner Author

pbiecek commented Jan 28, 2016

Next time I will use alink.
I've tested the generation of README.md (as here: https://github.com/pbiecek/Eseje/tree/master/arepo), functionality is impressive bur calls might be simplified. It took me some time to understand why repoDirGit has to be FALSE for root directory, sometimes it's logical value sometimes it's character. Maybe NULL instead of FALSE will be more consistent?
Anyway, will try alink in next occasion.

@MarcinKosinski
Copy link
Collaborator

repoDirGit is probably set to FALSE in other functions that interacts with github. So it's probably done in this way to maintain consistency

Marcin Kosinski

Dnia 28.01.2016 o godz. 20:35 Przemysław Biecek notifications@github.com napisał(a):

Next time I will use alink.
I've tested the generation of README.md (as here: https://github.com/pbiecek/Eseje/tree/master/arepo), functionality is impressive bur calls might be simplified. It took me some time to understand why repoDirGit has to be FALSE for root directory, sometimes it's logical value sometimes it's character. Maybe NULL instead of FALSE will be more consistent?
Anyway, will try alink in next occasion.


Reply to this email directly or view it on GitHub.

pbiecek added a commit that referenced this issue Feb 1, 2016
@pbiecek pbiecek added in progress and removed To do! labels Feb 1, 2016
@pbiecek
Copy link
Owner Author

pbiecek commented Feb 1, 2016

We have two approaches how to integrate with git( repos.
@MarcinKosinski shall we close this issue?

@MarcinKosinski
Copy link
Collaborator

@pbiecek you mean with archive/alink and pin/`addHooks ?
I thinks this is almost the same as #74 so we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants