Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions using git2r and GitHub API to archivist.git2r / archivist.github package #198

Closed
MarcinKosinski opened this issue Feb 6, 2016 · 8 comments
Assignees

Comments

@MarcinKosinski
Copy link
Collaborator

Remove documentation for and functionalities of

  • archive
  • pushRepo
  • pullRepo
  • deleteGithubRepo (also update deleteRepo)
  • createGithubRepo (also update createRepo)
  • cloneGithubRepo
  • ?agithub man page
@pbiecek
Copy link
Owner

pbiecek commented Feb 7, 2016

@MarcinKosinski do you need help in this? I can move this files today

@MarcinKosinski
Copy link
Collaborator Author

If you have more time then feel free. I was planning to do this in the
evening, but if this is better for you to do this earlier that it's ok for
me :)

2016-02-07 10:24 GMT+01:00 Przemysław Biecek notifications@github.com:

@MarcinKosinski https://github.com/MarcinKosinski do you need help in
this? I can move this files today


Reply to this email directly or view it on GitHub
#198 (comment).

@MarcinKosinski
Copy link
Collaborator Author

I have transfered mentioned above functions to https://github.com/MarcinKosinski/archivist.github

When I have implemented such integration I have changed createEmptyRepo to createEmptyLocalRepo and deleteRepo to deleteLocalRepo. For now we have 4 of them.
Should we leave only createEmptyLocalRepo and deleteLocalRepo and more createEmptyRepo and deleteRepo to deprecated?

After this is resolved I'll update NEWS.md

@pbiecek
Copy link
Owner

pbiecek commented Feb 7, 2016

I think that we should have either:

  • short functions like aread, asearch
  • full names, but here obligatory with either Local or Remote.
    (so deleteRepo - deprecated, deleteLocalRepo - default)
  • btw: maybe instead createEmptyLocalRepo we shall have createLocalRepo?
    then createEmptyLocalRepo may be deprecated

2016-02-07 22:14 GMT+01:00 Marcin Kosiński notifications@github.com:

I have transfered mentioned above functions to
https://github.com/MarcinKosinski/archivist.github

When I have implemented such integration I have changed createEmptyRepo
to createEmptyLocalRepo and deleteRepo to deleteLocalRepo. For now we
have 4 of them.
Should we leave only createEmptyLocalRepo and deleteLocalRepo and more
createEmptyRepo and deleteRepo to deprecated?

After this is resolved I'll update NEWS.md


Reply to this email directly or view it on GitHub
#198 (comment).

pozdrawiam serdecznie,
Przemysław Biecek

@MarcinKosinski
Copy link
Collaborator Author

Sounds good since I've added createGitHubRepo (without Empty) to
archivist.github

2016-02-07 22:25 GMT+01:00 Przemysław Biecek notifications@github.com:

I think that we should have either:

  • short functions like aread, asearch
  • full names, but here obligatory with either Local or Remote.
    (so deleteRepo - deprecated, deleteLocalRepo - default)
  • btw: maybe instead createEmptyLocalRepo we shall have createLocalRepo?
    then createEmptyLocalRepo may be deprecated

2016-02-07 22:14 GMT+01:00 Marcin Kosiński notifications@github.com:

I have transfered mentioned above functions to
https://github.com/MarcinKosinski/archivist.github

When I have implemented such integration I have changed createEmptyRepo
to createEmptyLocalRepo and deleteRepo to deleteLocalRepo. For now we
have 4 of them.
Should we leave only createEmptyLocalRepo and deleteLocalRepo and more
createEmptyRepo and deleteRepo to deprecated?

After this is resolved I'll update NEWS.md


Reply to this email directly or view it on GitHub
<#198 (comment)
.

pozdrawiam serdecznie,
Przemysław Biecek


Reply to this email directly or view it on GitHub
#198 (comment).

@MarcinKosinski
Copy link
Collaborator Author

Now I think that we could gather archive, createGithubRepo, deleteGithubRepo, cloneGithubRepo, puchGithubRepo and pullGithubRepo into one function, i.e. archive / agithub and this function could have method parameter which for

  • method = "create" would trigger createGithubRepo
  • method = "delete" would trigger deleteGithubRepo
  • method = "clone" would trigger cloneGithubRepo
  • method = "pull" would trigger pullGithubRepo
  • method = "push" would trigger pushGithubRepo

This is really simple functionality, and even when moving those functions to other package I thought I could create one function from them. I'm not so sure right now whether additional package is needed :)

@pbiecek
Copy link
Owner

pbiecek commented Feb 9, 2016

The nice thing about a new package is that there may be other extensions as
well,
like you have suggested archivist.dplyr or archivist.bitbucket.

Then we may really stop development of archivist and freeze changes here.
All extensions will be added to these new packages.

I am a bit afraid that always there will be something worth to add, but on
some point we should say that tis version is ''production ready' and users
should not bother that new things will come in a month or something

2016-02-09 13:48 GMT+01:00 Marcin Kosiński notifications@github.com:

Now I think that we could gather archive, createGithubRepo,
deleteGithubRepo, cloneGithubRepo, puchGithubRepo and pullGithubRepo into
one function, i.e. archive / agithub and this function could have method
parameter which for

  • method = "create" would trigger createGithubRepo
  • method = "delete" would trigger deleteGithubRepo
  • method = "clone" would trigger cloneGithubRepo
  • method = "pull" would trigger pullGithubRepo
  • method = "push" would trigger pushGithubRepo

This is really simple functionality, and even when moving those functions
to other package I thought I could create one function from them. I'm not
so sure right now whether additional package is needed :)


Reply to this email directly or view it on GitHub
#198 (comment).

pozdrawiam serdecznie,
Przemysław Biecek

@MarcinKosinski
Copy link
Collaborator Author

You've convinced me once again. Let's have archivist.github :)

2016-02-09 13:54 GMT+01:00 Przemysław Biecek notifications@github.com:

The nice thing about a new package is that there may be other extensions as
well,
like you have suggested archivist.dplyr or archivist.bitbucket.

Then we may really stop development of archivist and freeze changes here.
All extensions will be added to these new packages.

I am a bit afraid that always there will be something worth to add, but on
some point we should say that tis version is ''production ready' and users
should not bother that new things will come in a month or something

2016-02-09 13:48 GMT+01:00 Marcin Kosiński notifications@github.com:

Now I think that we could gather archive, createGithubRepo,
deleteGithubRepo, cloneGithubRepo, puchGithubRepo and pullGithubRepo into
one function, i.e. archive / agithub and this function could have method
parameter which for

  • method = "create" would trigger createGithubRepo
  • method = "delete" would trigger deleteGithubRepo
  • method = "clone" would trigger cloneGithubRepo
  • method = "pull" would trigger pullGithubRepo
  • method = "push" would trigger pushGithubRepo

This is really simple functionality, and even when moving those functions
to other package I thought I could create one function from them. I'm not
so sure right now whether additional package is needed :)


Reply to this email directly or view it on GitHub
<#198 (comment)
.

pozdrawiam serdecznie,
Przemysław Biecek


Reply to this email directly or view it on GitHub
#198 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants