Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are outdates and fail on CRAN #252

Closed
pbiecek opened this issue Feb 17, 2016 · 3 comments
Closed

tests are outdates and fail on CRAN #252

pbiecek opened this issue Feb 17, 2016 · 3 comments

Comments

@pbiecek
Copy link
Owner

pbiecek commented Feb 17, 2016

i.e. test_jss_artilce contains multiSearchInRemoteRepo

@pbiecek
Copy link
Owner Author

pbiecek commented Feb 17, 2016

On CRAN they have:

** running tests for arch 'i386' ... ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
testthat results ================================================================
OK: 47 SKIPPED: 0 FAILED: 4

  1. Error: asearch works properly

  2. Error: loadFromRepo functions works with regular parameters

  3. Error: search* functions does search

  4. Error: zip*Repo reacts properly on proper arguments

    Error: testthat unit tests failed
    In addition: Warning message:
    'multiSearchInRemoteRepo' is deprecated.
    Use 'multiSearchInRemoteRepo is deprecated. Use searchInRemoteRepo() instead.' instead.
    See help("Deprecated")
    Execution halted

I cannot reproduce these errors

pbiecek added a commit that referenced this issue Feb 17, 2016
@pbiecek
Copy link
Owner Author

pbiecek commented Feb 19, 2016

Something is wrong with test on Windows
https://cran.r-project.org/web/checks/check_results_archivist.html

@pbiecek
Copy link
Owner Author

pbiecek commented Feb 21, 2016

It turns out that tests fail because of slow internet connection.
Still, I think that tests should not be that heavily based on github.
Should be changes along #249

@pbiecek pbiecek closed this as completed Feb 21, 2016
@pbiecek pbiecek removed the ready label Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant