Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen(ts): support json_name option on encodeJson/decodeJson #286

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

finalchild
Copy link
Collaborator

@finalchild finalchild commented Oct 16, 2023

Use jsonName instead of tsName when json_name option is present on the field. This option is supported on official protobuf implementations.

Copy link
Member

@disjukr disjukr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disjukr disjukr merged commit 312579f into pbkit:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants