Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/ updates #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

debian/ updates #1

wants to merge 2 commits into from

Conversation

df7cb
Copy link

@df7cb df7cb commented Jan 8, 2020

No description provided.

Packaging files should all be inside debian/, and Makefile isn't needed,
the tarball will be downloaded by uscan using the debian/watch file.
@df7cb
Copy link
Author

df7cb commented Jan 8, 2020

Hi Paul,

I pushed some preliminary updates for the laz-perf package. I removed the Makefile because it's in the way for the actual sources when unpacking the tarball. To retrieve the tarball, there's now a debian/watch file that can be activated by running uscan from the devscripts package.

A few more things to do:

  • The Description doesn't say what the package is doing. What is LAZ?
    The "short" Description is okayish, but the long version (lines 2+) should introduce the package to a reader new to the subject.
  • debian/copyright needs a detailed list of all the (C) holders for all the files in there.
  • The contents of laz-perf_1.3.0-1_amd64.deb when building from this source are most likely incomplete.
*** Contents:
drwxr-xr-x root/root         0 2019-12-26 01:36 ./
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/include/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/include/laz-perf/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/include/laz-perf/common/
-rw-r--r-- root/root      1245 2018-07-12 15:01 ./usr/include/laz-perf/common/common.hpp
-rw-r--r-- root/root      7591 2018-07-12 15:01 ./usr/include/laz-perf/common/types.hpp
-rw-r--r-- root/root      6345 2018-07-12 15:01 ./usr/include/laz-perf/compressor.hpp
-rw-r--r-- root/root      6096 2018-07-12 15:01 ./usr/include/laz-perf/decoder.hpp
-rw-r--r-- root/root      5483 2018-07-12 15:01 ./usr/include/laz-perf/decompressor.hpp
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/include/laz-perf/detail/
-rw-r--r-- root/root      3274 2018-07-12 15:01 ./usr/include/laz-perf/detail/field_extrabytes.hpp
-rw-r--r-- root/root     16474 2018-07-12 15:01 ./usr/include/laz-perf/detail/field_gpstime.hpp
-rw-r--r-- root/root     15209 2018-07-12 15:01 ./usr/include/laz-perf/detail/field_point10.hpp
-rw-r--r-- root/root      7499 2018-07-12 15:01 ./usr/include/laz-perf/detail/field_rgb.hpp
-rw-r--r-- root/root      6229 2018-07-12 15:01 ./usr/include/laz-perf/detail/field_xyz.hpp
-rw-r--r-- root/root      7609 2018-07-12 15:01 ./usr/include/laz-perf/encoder.hpp
-rw-r--r-- root/root      2393 2018-07-12 15:01 ./usr/include/laz-perf/excepts.hpp
-rw-r--r-- root/root      8340 2018-07-12 15:01 ./usr/include/laz-perf/factory.hpp
-rw-r--r-- root/root     14004 2018-07-12 15:01 ./usr/include/laz-perf/formats.hpp
-rw-r--r-- root/root     31130 2018-07-12 15:01 ./usr/include/laz-perf/io.hpp
-rw-r--r-- root/root      2528 2018-07-12 15:01 ./usr/include/laz-perf/las.hpp
-rw-r--r-- root/root      2567 2018-07-12 15:01 ./usr/include/laz-perf/main.cpp
-rw-r--r-- root/root      8075 2018-07-12 15:01 ./usr/include/laz-perf/model.hpp
-rw-r--r-- root/root      2794 2018-07-12 15:01 ./usr/include/laz-perf/portable_endian.hpp
-rw-r--r-- root/root      2409 2018-07-12 15:01 ./usr/include/laz-perf/streams.hpp
-rw-r--r-- root/root      5040 2018-07-12 15:01 ./usr/include/laz-perf/util.hpp
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/lib/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/lib/cmake/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/lib/cmake/lazperf/
-rw-r--r-- root/root       251 2019-12-26 01:36 ./usr/lib/cmake/lazperf/lazperf-config.cmake
-rw-r--r-- root/root       380 2019-12-26 01:36 ./usr/lib/cmake/lazperf/lazperf-configVersion.cmake
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/share/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/share/doc/
drwxr-xr-x root/root         0 2019-12-26 01:36 ./usr/share/doc/laz-perf/
-rw-r--r-- root/root       152 2019-12-26 01:36 ./usr/share/doc/laz-perf/changelog.Debian.gz
-rw-r--r-- root/root         0 2019-12-26 01:36 ./usr/share/doc/laz-perf/copyright

A tarball of 4MB should probably install more than a few .hpp files.

@pblottiere
Copy link
Owner

Hi Christoph,

I pushed some preliminary updates for the laz-perf package.

Thanks a lot for this PR! I'm pleased to see that I'm going to learn a lot on the road :).

A few more things to do:

I'll take a look asap.

@alexmyczko
Copy link

Meanwhile 3.3.0 is out, do you plan to file an RFP or ITP bug? Keep working on it? I'm in a hurry and will look into packaging 3.3.0 right now, for cloudcompare, not sure if pdal needs build against laz-perf first... will figure out later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants