Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pros:
It will improve startup time (below 2 secs now on my project vs 16+ before).
Parsing php files is happening when they are actually required.
Caching index in file is not needed.
Cons:
Will have to bring it back for find reference if ever implemented. For now YAGNI.
May fail to import modules that are doing something fancy in
registration.php
, will deal with it if/when I encounter one.