fix: Inject pointer-events css into preview modal content #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboivin
force-pushed
the
fix/preview-modal-pointer-events
branch
from
6ef02cc
to
33a32a7
Compare
| return $htmlContent; | ||
| } | ||
|
|
||
| $style = '<style>body * { pointer-events: none !important; }</style>'; |
There was a problem hiding this comment.
Using just body as the selector will do because the property will naturally cascade. body * is unnecessary greedy and could cause performance issues with larger sites
https://stackoverflow.com/questions/2951997/what-is-the-performance-impact-of-the-universal-selector
There was a problem hiding this comment.
Thank you, I'll run some tests and fix it in the next patch release 👍️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12