Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fintechstudios fix/x forwarded for #51

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Fintechstudios fix/x forwarded for #51

merged 1 commit into from
Jun 1, 2022
+18 −9

Conversation

pbojinov
Copy link
Owner

@pbojinov pbojinov commented Jun 1, 2022

Fixing merge conflicts and merging this PR #33

@pbojinov pbojinov force-pushed the fintechstudios-fix/x-forwarded-for branch from 870ad70 to 89d7ff4 Compare June 1, 2022 05:40
@pbojinov pbojinov merged commit 37f7aa3 into master Jun 1, 2022
@pbojinov pbojinov mentioned this pull request Jun 1, 2022
Closed
@kortemy
Copy link

kortemy commented Jun 20, 2022

Yeah this PR broke the library :) Per MDN docs https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

image

OrtalCF
OrtalCF reviewed Jun 29, 2022
View reviewed changes
Copy link

@OrtalCF OrtalCF left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
this changes are MAJOR changes, u take the LAST instead of FIRST, u should change the version to 3.x.x and not keep it as 2.x.x

@YSaxon YSaxon mentioned this pull request Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrtalCF OrtalCF OrtalCF left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbojinov @kortemy @OrtalCF @austince