Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoundCI does not have the same rules as RuboCop #75

Closed
joeyparis opened this issue Sep 6, 2021 · 3 comments
Closed

HoundCI does not have the same rules as RuboCop #75

joeyparis opened this issue Sep 6, 2021 · 3 comments
Assignees

Comments

@joeyparis
Copy link
Contributor

HoundCI and RuboCop have conflicting rules that make committing code requests difficult as what satisfies local testing doesn't satisfy pull request testing.

I personally prefer the style choices we have set in Rubocop, but at least one of the two configurations should be updated to match each other.

@pboling
Copy link
Owner

pboling commented Mar 20, 2024

I'll cleanup the Rubocop Style rules with next release. Thanks for pointing it out!

@pboling pboling self-assigned this Mar 20, 2024
@pboling
Copy link
Owner

pboling commented Mar 23, 2024

I'm hopeful that this is resolved... but haven't tested with a PR yet.

@pboling
Copy link
Owner

pboling commented Apr 18, 2024

I'm not sure if this is resolved, as I haven't made a PR, but if this comes up again I'll look into it. RuboCop is much more constrained now since the addition of RuboCop-LTS.

@pboling pboling closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants