Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in opacity in favour of recommending hyper-opacity #1

Closed
kitten opened this issue May 27, 2018 · 2 comments
Closed

Remove built-in opacity in favour of recommending hyper-opacity #1

kitten opened this issue May 27, 2018 · 2 comments

Comments

@kitten
Copy link

kitten commented May 27, 2018

I'm personally not a big fan of terminal themes with opacity and I'd guess several others aren't either. It's a relatively straightforward piece of code to make Hyper slightly transparent, but there's also hyper-opacity:

https://hyper.is/plugins/hyper-opacity

As a conclusion, I don't think there's any need to include it by default in this theme and the readme could instead recommend this plugin instead 😉

@pbomb
Copy link
Owner

pbomb commented May 27, 2018

Nice, I wasn't aware of this plugin. I just pushed a change that removes the transparent background by default, with a specify property to enable it, but using the existing plugin you mentioned, which I wasn't aware of, is a better option. Getting ready to push changes to satisfy this suggestion. Thanks!

@pbomb pbomb closed this as completed in 2e64d88 May 27, 2018
@pbomb
Copy link
Owner

pbomb commented May 27, 2018

🎉 This issue has been resolved in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants