Array conversions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Array returns an array representation of uuid that can be used as a map key. | ||
| // Array panics if uuid is not valid. | ||
| func (uuid UUID) Array() Array { | ||
| if len(uuid) != 16 { |
There was a problem hiding this comment.
Why does this panic rather than return an error?
There was a problem hiding this comment.
My reasoning was that an error was too cumbersome. When the primary use of this type is to be used as a map key having a single return value is convenient.
m[u.Array()] = recordI figured a panic was better than an zero-values Array because it doesn't mask bugs (getting an array of a nil UUID seems like a bug to me).
There was a problem hiding this comment.
Makes sense. I agree that a nil UUID would be bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes discussed in #3 to achieve efficient map keys. The
Array.String()method was added for convenience.