Implement database/sql's Scanner interface. Fixes #5 #6
Conversation
|
|
||
| import ( | ||
| "database/sql" | ||
| "database/sql/driver" |
There was a problem hiding this comment.
I would be fine with Scan, but I do not want to pull a dependency in on sql or sql driver. That would force the inclusion of sql and sql/driver in every application that uses UUID's. Seems to me the functionality should live in an sql library. You can simmly have sql/uuid which has "type UUID struct { uuid.UUID } and then define your new types on (or I believe you can).
There was a problem hiding this comment.
Ok fair enough. I'll remove the dep on sql and sql/driver. The sql dep is only there for the little check I added in to make sure it implements the interface at compile time. I'll submit an update with just Scan implemented.
jboverfelt
changed the title
|
I updated this PR to only implement sql.Scanner, thus removing the dep on database/sql. I also improved the coverage to be 100% of sql.go. Let me know if this works. |
| case string: | ||
| // see uuid.Parse for required string format | ||
| str := src.(string) | ||
| parsed := Parse(str) |
There was a problem hiding this comment.
No reason for the temporary variable here.
parsed := Parse(src.(string))
For consistency, probably use u instead of parsed (so it matches below)
|
|
||
| *uuid = u | ||
| default: | ||
| return fmt.Errorf("Scan: Unable to scan type %T into UUID", src) |
jboverfelt
force-pushed
the
sql-scanner
branch
from
0ba88eb
to
57e7d3a
Compare
jboverfelt
force-pushed
the
sql-scanner
branch
from
57e7d3a
to
7464a23
Compare
Implement database/sql's Scanner interface. Fixes #5
Hi! This PR adds an implementation of sql.Scanner for convenience when working with uuids in SQL databases. sql.Scanner allows the reading of uuid values from a database directly into a uuid.UUID.
The implementation of sql.Scanner provided can read values as strings (assumed to be in the format uuid.Parse accepts) or plain byte slices.
I've written test cases that provide full coverage and have tested this out with sqlite3 using a test harness that I can provide if you're interested.
Please let me know if you have any questions or if you would like me to change anything about the implementation.