Memory leak

[Gerrit0]

cheeseshop/cheeseshop.cpp

Lines 34 to 38 in e2f38de

	CheeseShop &operator=(CheeseShop &&other) noexcept {
	inventory = std::move(other.inventory);
	clerkName = other.clerkName;
	other.clerkName = nullptr;

This code has a memory leak if I have a CheeseShop which already has a clerkName pointer

It'd be better to use a std::unique_ptr here, though I get why you didn't given the subject of your post... raw pointers are almost always a bad idea.

[pboyd]

Good point, thank you. I'll fix it and update the post (though I won't have a chance for a few days).

…

-------- Original Message --------

On May 12, 2024, 4:26 PM, Gerrit Birkeland wrote: https://github.com/pboyd/cheeseshop/blob/e2f38decf48875f8bdef7555d63c66931902bcde/cheeseshop.cpp#L34-L38 This code has a memory leak if I have a CheeseShop which already has a clerkName pointer It'd be better to use a std::unique_ptr here, though I get why you didn't given the subject of your post... raw pointers are almost always a bad idea. — Reply to this email directly, [view it on GitHub](#1), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AABHQQIVANMLTMZJ5USG3TLZB7F7XAVCNFSM6AAAAABHTCQ7ECVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4TCNBYHA3TCNQ). You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[pboyd]

This has been fixed. Thanks again.