Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make appVersion Text instead of Data.Version.Version #29

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Make appVersion Text instead of Data.Version.Version #29

merged 1 commit into from
Jun 26, 2018

Conversation

MaxGabriel
Copy link
Contributor

  • This allows using e.g. Git SHAs as the version, for users who deploy on every commit instead of assigning version numbers
  • This better reflects Bugsnag's API which allows for arbitrary version numbers, without an a.b.c convention

@pbrisbin
Copy link
Owner

Hey thanks! This LGTM. I don't know why Circle ignored it (I do have "Build Forked Pull Requests" enabled). Do you mind doing a quick amend+force-push, to see if Circle notices it?

@pbrisbin pbrisbin self-requested a review June 26, 2018 12:38
@MaxGabriel
Make appVersion Text instead of Data.Version.Version
d5d0166 
* This allows using e.g. Git SHAs as the version, for users who deploy on every commit instead of assigning version numbers
* This better reflects Bugsnag's API which allows for arbitrary version numbers, without an a.b.c convention
@MaxGabriel
Copy link
Contributor Author

Ok, I force pushed an amended commit. Not sure if that'll trigger CI though

@MaxGabriel
Copy link
Contributor Author

Doesn't seem to have worked 🤷‍♀️

@pbrisbin
Copy link
Owner

Weird. Thanks anyway.

@pbrisbin pbrisbin merged commit ac40ebb into pbrisbin:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrisbin pbrisbin Awaiting requested review from pbrisbin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxGabriel @pbrisbin