Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merith/fix322 #323

Merged
merged 2 commits into from
May 1, 2024
Merged

Merith/fix322 #323

merged 2 commits into from
May 1, 2024

Conversation

Merith-TK
Copy link
Contributor

Fixes #322

Fix: ImproperVariables

  • Added a check if host is windows, and to use the proper variables there.
  • Visually nothing has changed, output will still look like HOME: C:/Users/Username

Fix: Missing GitConfig Entries prevent commit

  • Fixes deal better with case where native user hasn't configures user.name/email #272
  • When user.email and user.name are not found, git would fail to commit and throw the error to the logs, while the user would be told both "error running command" AND "backup successful"
  • I set these values in the worlds gitconfig on init as the following
    • user.name: <fastbackWorldID>
    • user.email: <fastbackWorldID>@fastback
  • I only do this on init to allow for users manually altering the config.

@Merith-TK
Copy link
Contributor Author

force push done to squash commits and sign commit

@Merith-TK
Fix Windows Variables, Fix missing gitconfig preventing commit
7de3286 
added a check if host is windows before printing values

fix missing user.name and user.email configuration breaking native git

git would fail to commit entirely if `user.email` and `user.name` were not set, the solution I implemented was to set that to `email: <fastbackWorldID>@fastback` and `user: <fastbackWorldID>`
@pcal43
Copy link
Owner

pcal43 commented May 1, 2024 •
edited
Loading

Cool, looks good. Thanks

@pcal43 pcal43 merged commit e0336c0 into pcal43:main May 1, 2024
@pcal43 pcal43 self-requested a review May 1, 2024 06:19
pcal43
pcal43 reviewed May 1, 2024
View reviewed changes
Copy link
Owner

@pcal43 pcal43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@Merith-TK
Copy link
Contributor Author

advantage to this is that it actually can be used to help filter commits to a repo based off the world if the user opts to not change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcal43 pcal43 pcal43 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Merith-TK @pcal43