Merge pull request #405 from eyal0/milldrill_toolchange

Do a toolchange before milldrilling
pcb2gcode · Mar 18, 2020 · a0be5c5 · a0be5c5
2 parents 58c715c + 077d7c0
commit a0be5c5
Show file tree

Hide file tree

Showing 23 changed files with 189 additions and 5 deletions.
diff --git a/drill.cpp b/drill.cpp
@@ -600,11 +600,19 @@ void ExcellonProcessor::export_ngc(const string of_dir, const boost::optional<st
     of << " )\n\n";
 
     //preamble
-    of << preamble_ext << preamble << "S" << left << target->speed
-       << "    (RPM spindle speed.)\n" << "G01 F" << target->feed * cfactor
-       << " (Feedrate)\nM3        (Spindle on clockwise.)\n"
-       << "G04 P" << target->spinup_time
-       << "\nG00 Z" << target->zsafe * cfactor << "\n\n";
+    of << preamble_ext << preamble
+       << "S" << left << target->speed << "    (RPM spindle speed.)\n\n"
+       << "G01 F" << target->feed * cfactor << " (Feedrate)\n"
+       << "G00 Z" << target->zchange * cfactor << " (Retract)\n"
+       << "T" << (*holes.begin()).first << "\n"
+       << "M5        (Spindle stop.)\n"
+       << "G04 P" << target->spindown_time << "\n"
+       << "(MSG, Change tool bit to drill size " << (bMetricOutput ? (target->tool_diameter * 25.4) : target->tool_diameter) << (bMetricOutput ? "mm" : "inch") << ")\n"
+       << "M6        (Tool change.)\n"
+       << "M0        (Temporary machine stop.)\n"
+       << "M3        (Spindle on clockwise.)\n"
+       << "G04 P" << target->spinup_time << "\n"
+       << "G00 Z" << target->zsafe * cfactor << "\n\n";
 
     tiling->header( of );
 

diff --git a/testing/gerbv_example/milldrilldiatest/expected/milldrill.ngc b/testing/gerbv_example/milldrilldiatest/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G21       (Units == Millimeters.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S2000    (RPM spindle speed.)
+
 G01 F600.00000 (Feedrate)
+G00 Z10.00000 (Retract)
+T6
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 1.00000mm)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z1.50000

diff --git a/testing/gerbv_example/multivibrator-basename/expected/testbase_name_milldrill.ngc b/testing/gerbv_example/multivibrator-basename/expected/testbase_name_milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-clockwise/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-clockwise/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.07087inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-contentions/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-contentions/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-extra-passes-big/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-extra-passes-big/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/...ng/gerbv_example/multivibrator-extra-passes-two-isolators-tiles-al/expected/milldrill.ngc b/...ng/gerbv_example/multivibrator-extra-passes-two-isolators-tiles-al/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-extra-passes-two-isolators-tiles/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-extra-passes-two-isolators-tiles/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-extra-passes-two-isolators/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-extra-passes-two-isolators/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-extra-passes-voronoi/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-extra-passes-voronoi/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-extra-passes/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-extra-passes/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-identical-isolators/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-identical-isolators/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-no-tsp-2opt/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-no-tsp-2opt/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-no-zbridges/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-no-zbridges/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator-two-isolators/expected/milldrill.ngc b/testing/gerbv_example/multivibrator-two-isolators/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator/expected/milldrill.ngc b/testing/gerbv_example/multivibrator/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator_no_zero_start/expected/milldrill.ngc b/testing/gerbv_example/multivibrator_no_zero_start/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator_pre_post_milling_gcode/expected/milldrill.ngc b/testing/gerbv_example/multivibrator_pre_post_milling_gcode/expected/milldrill.ngc
@@ -15,7 +15,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator_xy_offset/expected/milldrill.ngc b/testing/gerbv_example/multivibrator_xy_offset/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/multivibrator_xy_offset_zero_start/expected/milldrill.ngc b/testing/gerbv_example/multivibrator_xy_offset_zero_start/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.03150inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/slots-milldrill-metric/expected/milldrill.ngc b/testing/gerbv_example/slots-milldrill-metric/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G21       (Units == Millimeters.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F2540.00000 (Feedrate)
+G00 Z25.40000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 2.54000mm)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z2.03200

diff --git a/testing/gerbv_example/slots-milldrill/expected/milldrill.ngc b/testing/gerbv_example/slots-milldrill/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T1
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.10000inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000

diff --git a/testing/gerbv_example/slots-with-drill-and-milldrill/expected/milldrill.ngc b/testing/gerbv_example/slots-with-drill-and-milldrill/expected/milldrill.ngc
@@ -8,7 +8,15 @@ G20       (Units == INCHES.)
 G91.1     (Incremental arc distance mode.)
 G90       (Absolute coordinates.)
 S10000    (RPM spindle speed.)
+
 G01 F100.00000 (Feedrate)
+G00 Z1.00000 (Retract)
+T2
+M5        (Spindle stop.)
+G04 P1.00000
+(MSG, Change tool bit to drill size 0.04000inch)
+M6        (Tool change.)
+M0        (Temporary machine stop.)
 M3        (Spindle on clockwise.)
 G04 P1.00000
 G00 Z0.08000