Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove surface.cpp and surface.hpp #309

Merged
merged 8 commits into from
Mar 7, 2019
Merged

Remove surface.cpp and surface.hpp #309

merged 8 commits into from
Mar 7, 2019

Conversation

eyal0
Copy link
Contributor

@eyal0 eyal0 commented Mar 4, 2019

This fixes #308

@eyal0 eyal0 force-pushed the remove_old_surface branch 3 times, most recently from 51b91ad to c0b3528 Compare March 6, 2019 02:29
@eyal0 eyal0 closed this Mar 6, 2019
@eyal0 eyal0 deleted the remove_old_surface branch March 6, 2019 02:29
@eyal0 eyal0 restored the remove_old_surface branch March 6, 2019 02:31
@eyal0 eyal0 reopened this Mar 6, 2019
@coveralls
Copy link
Collaborator

coveralls commented Mar 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1141

  • 41 of 46 (89.13%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+8.6%) to 93.375%
Changes Missing Coverage Covered Lines Changed/Added Lines %
surface_vectorial.cpp 5 6 83.33%
autoleveller.cpp 6 8 75.0%
options.cpp 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
options.cpp 1 83.67%
Totals Coverage Status
Change from base Build 1140: 8.6%
Covered Lines: 3425
Relevant Lines: 3668
💛 - Coveralls

@eyal0 eyal0 merged commit 180eb49 into pcb2gcode:master Mar 7, 2019
@eyal0 eyal0 deleted the remove_old_surface branch October 28, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove surface.cpp and related code
2 participants
@eyal0 @coveralls