Gentoo support, NVMe disks as HDRIVE, Desktop specification fixes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved Categories from Link type Desktop Entry.
|
Ok, It all looks good aside from removing the "Categories" definition in the lumina-support.desktop file. We have/had a ticket about that specific thing already (#183), and the categories field needs to be defined for the entry to show up within the app menu properly (see the other ticket for details). Could you remove that change, and update your pull request again? Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ken,
Here's the pull request! In it you'll find:
1: Gentoo support: libLumina/LuminaOS-Gentoo.cpp and ebuild file lumina-0.9_pre.ebuild. I've tested the ebuild quite extensively. In the future, I will also add USE FLAG support, so you can turn stuff on and off, for example, experimental WM support and such.
2: I noticed that the HDRIVE finder routine classifies /dev/sd[a-z] on Linux-likes. However, if one has an NVMe style SSD drive, a device will show up as /dev/nvme*; I've added an OR to the test for HDRIVE in Linux and Debian LuminaOS files.
3: I noticed that Gentoo's desktop file specification verifier caught a few small deficiencies in two desktop files. I corrected those.