no visible binding for global variable 'wb'

[ddsjoberg]

I don't think I quite understand how these functions use the bare wb as a default argument? Can we update somehow to remove the note from R CMD Checks?

N  checking R code for possible problems (3.1s)
   add_labelled_sheet: no visible binding for global variable 'wb'
   labelled_sheet: no visible binding for global variable 'wb'
   Undefined global functions or variables:
     wb

[Meghansaha]

addressed in #31, needs review @ddsjoberg.

[ddsjoberg]

The NOTE is due to the default argument add_labelled_sheet(wrkbk = wb): the object wb does not exist/not defined.

I would make the update something like this:

add_labelled_sheet <- function(data, sheet_name = NULL, wrkbk = NULL, start_row = 1L){
  wrkbk <-
    wrkbk %||%
    tryCatch(
      get("wb", envir = rlang::caller_env()),
      error = function(e) {
        paste(
          "The {.code wrkbk} argument has not been specified,",
          "and the default object {.field wb} does not exist in the calling environment."
        ) |>
          cli::cli_abort()
      }
    )

This update applies to both labelled_sheet() and add_labelled_sheet().

Let's also check-in with @shannonpileggi if this solution is amenable for her. We don't want to accidentally make a breaking change (although I don't think this will be one).

[Meghansaha]

lol this was similar, but more elegant to what I was about to write, and yes we should consult with @shannonpileggi. If she's fine with this, I can implement it on my branch I created for this.

[ddsjoberg]

since it's a small update, go ahead and prepare the pull request and shannon can reivew

[ddsjoberg]

complete