Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client abstraction layer missing? Per PLC (=target net ID) with configurable port #13

Closed
klauer opened this issue Feb 4, 2021 · 1 comment · Fixed by #14
Closed

Comments

@klauer
Copy link
Contributor

klauer commented Feb 4, 2021

Background

Preface: so long as the client is used with only a single target net ID, there should be no problem using the current implementation.

I had thought I wanted a context manager for the existing client to set a target net_id/port for a given block, but what I think may be missing is a "PLC" - a per-(target net id) with a configurable port. A client can communicate to any number of target net IDs (assuming the routing happens on the target end).

Todo

Need to look more into this one day:

  • On the protocol level, tracking of handles and such may be insufficient? (i.e., should it be keyed on (source_addr, handle)?)
  • Analogous to the caproto "VirtualCircuit", create a "PLC"/"Connection"/"Circuit" class to represent this layer
@klauer
Copy link
Contributor Author

klauer commented Feb 8, 2021

It's entirely possible this should be taken a bit further, even - by (net_id, port). It wouldn't be difficult to extend to this with the codebase as-is, at least.

@klauer klauer closed this as completed in #14 Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant