Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: "Circuit" concept (AMS Net ID to AMS Net ID) transport over Connection (TCP) #14

Merged
merged 18 commits into from
Feb 8, 2021

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Feb 8, 2021

Description

  • Adds "Circuit" concept (AMS Net ID <-> AMS Net ID) transport over Connection (TCP <-> TCP)
    May be an existing TwinCAT term for this, but I couldn't really find it. Somewhat mirrors VirtualCircuit from caproto.
  • Cleans up style with black (it gets painful with type annotations of this level)

Motivation and Context

Closes #13
Closes #9

How Has This Been Tested?

Local testing. Paired with pcdshub/ads-log-daemon#2

@klauer
Copy link
Contributor Author

klauer commented Feb 8, 2021

Better than before, at least. I'm now more comfortable with this library's inclusion into ads-log-daemon.

@klauer klauer merged commit 2c5c04a into pcdshub:master Feb 8, 2021
@klauer klauer deleted the refactor branch February 8, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant