-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX/ENH: local mode based on nodejs implementation #40
Conversation
Test suite is hitting into pytmc changes in TMC handling, specifically from this PR: Looks like ads-async needs to dig down into the base type for AMSNETID and represent it as a string of bytes. My recollection of my implementation here for this is rather hazy though so fixing the test suite may take a bit. That said, there's still other stuff to be done:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be my least informed green stamp in a while. may prototypes be prototype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks useful, no reason to let it sit in limbo forever
I'm going to merge and pretend like I don't care about the CI at all |
Description
Enable client communication with the ADS server running on localhost for TwinCAT BSD systems.
Motivation and Context
localhost
) requires that you reserve a port from the router (and hopefully release it when you're done)(*) If we want to get ads-ioc working on TwinCAT/BSD through linuxemu we're going to have to replicate this there somehow.
How Has This Been Tested?
Where Has This Been Documented?
This PR
Screenshots (if appropriate):