FIX: authorization headers on Typhos help widget redirect #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauer
changed the title
ZLLentz
reviewed
Oct 12, 2021
| @@ -15,7 +15,7 @@ def _warn_unhandled(instance, metadata_key, value): | |||
| if value is None: | |||
| return | |||
|
|
|||
| logger.warning( | |||
| logger.debug( | |||
There was a problem hiding this comment.
Begone, annoying log messages!
ZLLentz
reviewed
Oct 12, 2021
| self, level, message, line_number, source_id | ||
| ): | ||
| """ | ||
| This hook redirects javascript console messages to Python logging. |
There was a problem hiding this comment.
A++ this is something that I need to duplicate in pmps-ui
ZLLentz
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Everything here seems reasonable, I agree with putting the web stuff into its own submodule (I've had trouble finding it before) and I think you've gone to the correct level in making sure we don't share our credentials with arbitrary websites that we may find links to on confluence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
typhos.web(to isolate and also move web log messages to a different logger instance)TYPHOS_HELP_HEADERS_HOSTSenv variable)Motivation and Context
New confluence release includes a redirect, so our help system wasn't working with access tokens only being set on the first go.
How Has This Been Tested?
Interactively.
Where Has This Been Documented?
Mostly in this PR text and docstrings.
Screenshots (if appropriate):