Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: direct-to-PV vs signal protocol by way of cl #463

Merged
merged 1 commit into from Nov 18, 2021

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Nov 18, 2021

Description

Typhos supports two paths to get data from ophyd Signals.

  1. Peeking into the EpicsSignal to see which PVs it is using and passing that along to PyDM
  2. Directly through the ophyd subscription mechanism

This PR allows for an escape hatch for (1) in scenarios where we want typhos to use method (2).
This escape hatch comes in the form of a control layer cl check to see if the user has customized it beyond what ophyd supports.

Motivation and Context

Related to pcdshub/atef#17
Where we want archived data to be sourced rather than live data

How Has This Been Tested?

Interactively, so far

Where Has This Been Documented?

This PR text.

Screenshots (if appropriate):

This is a typhos screen using this PR that gets data from the EPICS archiver:
image

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much simpler than I thought it would be. I didn't notice that the control layers had name attributes.

@ZLLentz ZLLentz merged commit 4234b6a into pcdshub:master Nov 18, 2021
@klauer klauer deleted the ref_direct_control_layers branch November 18, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants