Skip to content

Commit

Permalink
ipxe: change to autoboot only from net0
Browse files Browse the repository at this point in the history 
Signed-off-by: Kamil Wcislo <kamil.wcislo@3mdeb.com>
  • Loading branch information
Kamil Wcislo committed Dec 18, 2016
1 parent f2cbcb7 commit f88f7f6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ipxe/menu.ipxe
View file
Expand Up @@ -7,11 +7,11 @@ item boot autoboot
choose --default boot --timeout 3000 target && goto ${target}

:boot
autoboot
autoboot net0
goto MENU

:shell
shell ||
goto MENU

autoboot
autoboot net0

6 comments on commit f88f7f6

@wiegvlieg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Why would you changes this to only net0? We want to boot from interface net2 for example and this is now not possible. Why you would not leave it to just autoboot?

Kind Regards, Wieger IJntema

@pietrushnic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiegvlieg yes, this is a valid point. We probably changed that because most devices booting from net0, but because this propagates to publicly released firmware binaries it may lead to problems. Hopefully, no one else made assumptions based on this script.

This can't be blocking issue since you can easily rebuild ipxe according to your requirements and replace it in firmware binary.

@miczyg1 let's discuss this topic and if agreed then include fix for that in v4.8.0.4 and maybe legacy.

@miczyg1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietrushnic @wiegvlieg I think we keep the net0 as only interface for some reason. I am against changing that without further consultation with all decision makers.

@wiegvlieg as @pietrushnic says, it can be changed easily. This is open source repository and You are free to modify and build Your own firmware if You are confident with Your skills. However keep in mind that any deviations from our configuration may require more effort from us to help with any problems.

@wiegvlieg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietrushnic you are correct, after I found out that you can create your custom firmware i was able to locate and change the menu.ipxe script.

@miczyg1 I would directly not agree with you. As you may know Wake On Lan is only supported from net2 (the Ethernet port that is closest to the USB port) therefore we wanted our management interface to be net2. At first we could not find out why the APU2 was not automatically iPXE booting from net2. As the menu suggested that is would do a full loop over all the interfaces because is says autoboot in the automatic boot menu of iPXE and not autoboot net0. Also default behaviour should follow the normal described behavior as described by iPXE autoboot command. https://ipxe.org/cmd/autoboot
I also think the the single autoboot command is more generic and is also inline with how PC and servers treat PXE booting via interfaces.

Therefore it would more sense to change it back to autoboot and then people that want custom configuration can modify there firmware to there needs.

Is that not a better approach?

@miczyg1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiegvlieg I unserstand Your reasoning, however this change would quite radically change board behaviour. I did not say "do not change it no matter what", I Just meant only to point that decision should not be made up in a rush. I agee that, it is unconvenient to have only single network interface to autoboot. If all decision makers will agree to make the change, it will be included in next release.

@pietrushnic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiegvlieg We didn't know about WoL problem. Maybe correct thing is to make WoL work on all ports - I'm not sure if the hardware is prepared for that.

Anyway, @miczyg1 I think we need regression testing for that stuff. I believe @wiegvlieg is right and autoboot when we really doing autoboot netX is wrong, since user really can't see what is inside the script. We should make sure that our production firmware do what it claims to do.

@wiegvlieg thank you for taking time and figuring out the problem - the conclusion is that open source rulez since with hidden code it would be much harder to spot. I'm still worried that now someone can rely on autoboot net0, but things should work in most cases I believe.

@miczyg1 let's target that on v4.8.0.4 and legacy update and let's link to this discussion for further reference.

Please sign in to comment.