Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature set #90

Closed
wants to merge 6 commits into from
Closed

Add feature set #90

wants to merge 6 commits into from

Conversation

miczyg1
Copy link
Member

@miczyg1 miczyg1 commented May 24, 2018

No description provided.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
@miczyg1
Copy link
Member Author

miczyg1 commented May 24, 2018

@pietrushnic I believe there is more to add.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Copy link
Member

@pietrushnic pietrushnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 this is very good base, but target should extend by what user use e.g. supported operating systems netboot, storage boot, installation, supported/tested hardware list etc. We should probably have features that reflect bugs we had e.g. DMI since it looks like people and distros care about that.


`*` - apu5 has no support for S1
`**` - only mainline releases
`***` - apu3 seems to have inverted functionality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 asterisk render incorrectly in one line not in 3. Terminology is confusing e.g. one start is for S1 and serials console, but description say about S1. Please read it through again and fix.

| Boot menu timeout 6s | YES |
| F10 button to enter boot menu | YES |
| Custom boot menu string | YES |
| N for PXe boot string | YES |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 iPXE

| F10 button to enter boot menu | YES |
| Custom boot menu string | YES |
| N for PXe boot string | YES |
| PXE shadowing | YES |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 I'm not sure what is this.

| BIOS WP enable/disable | YES |
| Restore default options | YES |
| EHCI0 enable/disable | YES |
| Bootorder is aligned correctly | YES |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 security registers?

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Copy link
Member

@pietrushnic pietrushnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more please try to adjust that. I know that those changes can be annoying, but I think the vision of this document clarifies right now. This would be the fundament for further testing.

One more thing is that for coreboot features support we should have https://www.coreboot.org/Board:pcengines/apu2#Status and figure out how to test that. Maybe just linking to that page would be enough but we have to fill table and prepare tests for that.

`*` - apu5 has no support for S1
`**` - only mainline releases
`***` - apu3 seems to have inverted functionality
1) - apu5 has no support for S1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 please check how it renders to html this - doesn't help IMO. Maybe there should be column per platform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 I believe each feature should be divided per platform


| OS | Netinst | USB | SD | SATA | mSATA |
|----|---------|-----|----|------|-------|
| Debian stable x64 | YES | YES | YES | YES | YES |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 official name for that is amd64

Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
@@ -0,0 +1,105 @@
PC Engines apu feature set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 in future we plan also to add alix

@@ -0,0 +1,105 @@
PC Engines apu feature set
==========================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 we would like to have also TOC

PC Engines apu feature set
==========================

## Coreboot features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 let's try to follow https://www.coreboot.org/Board:pcengines/apu2 by dividing this document between platforms (one one md or multilple md). So we should have device/functionality, status, comment and test case. Our target is to have the same styling as coreboot feature list but one more column with a test case.

So this page should be divided between platforms apu1/2/3/4/5 and in future alix.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
| Debian stable amd64 | SD | | | |
| Debian stable amd64 | SATA | | | |
| Debian stable amd64 | mSATA | | | |
||||||
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These empty rows acts pretty good as a seperators @pietrushnic

@miczyg1
Copy link
Member Author

miczyg1 commented May 7, 2019

@pietrushnic do You think continuing oin this PR makes sense? Since we have theory of operation for features and asciinema? #143

@pietrushnic
Copy link
Member

@miczyg1 no it doesn't make sense it is an outdated approach - I wonder what would be a new way of confirming if the platform is supported in coreboot. We will see.

@pietrushnic pietrushnic closed this May 7, 2019
@miczyg1 miczyg1 deleted the add_feature_set branch May 8, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants